Repository navigation
Conversation
openlineage-dbt emits dbt_model (DbtModelDatasetFacet) with _schemaURL .../integration/common/openlineage/schema/dbt-model-dataset-facet.json, but that file is not published at any OpenLineage tag or on main; the facet exists only in facets.py. Syntax validation therefore fails with "facet type dbt_model not recognized". Treat it like dbt_version and dbt_run until upstream publishes the schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dbt syntax validation fails on recent openlineage-dbt releases with
facet type dbt_model not recognized.openlineage-dbt has emitted the
dbt_modeldataset facet (DbtModelDatasetFacet) since about 1.47, with_schemaURL…/integration/common/openlineage/schema/dbt-model-dataset-facet.json. That schema file doesn't exist at any OpenLineage tag or onmain: the facet is defined only inintegration/common/src/openlineage/common/provider/dbt/facets.py. The validator has no schema to load, so the facet is reported as unrecognized.Change
Add
dbt-model-datasetto the list of common facets whose schema validation is skipped, next todbt-version-runanddbt-run-run. This should be reverted once upstream publishes the schema.Verification
Full dbt validation of the 1.54 events from CI run 38702151241 passes 23/23 with this change.
Note
#257 rewrites the same
is_custom_facetfunction and validatesdbt-runanddbt-versionagainst their schemas instead of skipping them. Whichever PR merges second needs to keepdbt_modelskipped, because it has no schema upstream.🤖 Generated with Claude Code