Repository navigation
Conversation
Problem is, on PC, the top byte of KH1 remastered asset original offset is NOT part of the offset. It's an index into the games table of ps2 texture sizes. The game uses this size to work then out each HD textures scale. (HD width ÷ PS2 width) A face patch frame is now only copied onto it's Texture when both have the same scale, if the scale should differ, then the frame is skipped and the face will blink gray on every frame it will be picked. (similar to KH2) Panacea kept the retail indexes when it replaced a dds texture, so a custom models texture inherited the original characters PS2 size. So for example: Sora's face Texture uses index 7 (256x256, HD 1024x1024 texture times x4) A 512x256 replacement keeps index 7 and counts then as x2, so every patch frame was skipped. So the new fix is that panacea reads it's width and height from the dds header and finds the table entry and if it's a multiple of 4, then 2, 8 or 1, then writes that index into the top byte of origOffset;. the offset itself, the low 24 bits will be unchanged. oh yeah tested on Steam AND Epic. Tested with my Custom Ventus at different scale and frames. Completely custom. tested with 32x32, 128x64, 80x40.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem is, on PC, the top byte of KH1 remastered asset original offset is NOT part of the offset. It's an index into the games table of ps2 texture sizes. The game uses this size to work then out each HD textures scale. (HD width ÷ PS2 width)
A face patch frame is now only copied onto it's Texture when both have the same scale, if the scale should differ, then the frame is skipped and the face will blink gray on every frame it will be picked. (similar to KH2)
Panacea kept the retail indexes when it replaced a dds texture, so a custom models texture inherited the original characters PS2 size.
So for example: Sora's face Texture uses index 7 (256x256, HD 1024x1024 texture times x4) A 512x256 replacement keeps index 7 and counts then as x2, so every patch frame was skipped.
So the new fix is that panacea reads it's width and height from the dds header and finds the table entry and if it's a multiple of 4, then 2, 8 or 1, then writes that index into the top byte of origOffset;. the offset itself, the low 24 bits will be unchanged.
oh yeah tested on Steam AND Epic. Tested with my Custom Ventus at different scale and frames. Completely custom. tested with 32x32, 128x64, 80x40 resolutions, via debug log, to check what the game actually holded and why it skipped.
PS: Hopefully my last fix, I can't stand kh1 :s0wa: