Repository navigation
load remastered assets for recom, ddd and kh1 etc. - #1307
Merged
Merged
Conversation
Before panacea builded each remastered asset list from the games own list in the pkg and files in a mods remastered/file folder could then only replace certain entries that we are in that exactly that list. Textures or Assets with new names we're dropped. Which means custom models and textures did load, but got cut off the extra textures, simply because the offset did not longer matched the modded file. So for Recom/DDD: These now look up remastered textures/assets by the name and mod files replace originals with the same name too. So If sora has original 2 textures. The modded file can make now use of more than 2 textures for example, with custom names too. For KH1: the mod file with the original name replaces now the file and keeps it's original offset. The new file is added with it's offset taken from exactly that name.... A cvbl is matched by the name. From the base game... so it does get -1. the original file whose offset was taken by the new mod file is removed, so a rebuilded models hd textures, model, shadow, effect etc. lands on the new layout. Added a debug log on what final asset is printed for each file :stare: TESTED!!! KH1 Sora completely replaced with a rebuild of an mdls with shortend Model Block, tighter packet etc. Loads fine, no Issues at all. Including the cvbl. Also tested DDD Kairi from pmo to mdls + cvbl, with a bone count of 109, 121 and 125. With keyblade bones and IK bones. Including the mset replacement to test a custom animation for each of these bone counts. Also tested on PS2 aswell. (by Napstio, thanks btw. for testing.) I kept myself under the Memory Limit too. For RECOM/DDD I loaded my Custom Ventus and added more textures, to test where the new textures land exactly thanks to panacea's "If 0" switch. So yeah new Textures are working too. PS: I hate KH1. I HATE IT!!!
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Contributor
|
LGTM, based even. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before panacea builded each remastered asset list from the games own list in the pkg and files in a mods remastered/file folder could then only replace certain entries that we are in that exactly that list. Textures or Assets with new names we're dropped. Which means custom models and textures did load, but got cut off the extra textures, simply because the offset did not longer matched the modded file.
So for Recom/DDD:
These now look up remastered textures/assets by the name and mod files replace originals with the same name too. So If sora has original 2 textures. The modded file can make now use of more than 2 textures for example, with custom names too.
For KH1:
the mod file with the original name replaces now the file and keeps it's original offset. The new file is added with it's offset taken from exactly that name.... A cvbl is matched by the name. From the base game... so it does get -1. the original file whose offset was taken by the new mod file is removed, so a rebuilded models hd textures, model, shadow, effect etc. lands on the new layout.
Added a debug log on what final asset is printed for each file :stare:
TESTED!!!
KH1 Sora completely replaced with a rebuild of an mdls with shortend Model Block, tighter packet etc. Loads fine, no Issues at all. Including the cvbl. Also tested DDD Kairi from pmo to mdls + cvbl, with a bone count of 109, 121 and 125. With keyblade bones and IK bones. Including the mset replacement to test a custom animation for each of these bone counts. Also tested on PS2 aswell. (by Napstio, thanks btw. for testing.) I kept myself under the Memory Limit too.
For RECOM/DDD I loaded my Custom Ventus and added more textures, to test where the new textures land exactly thanks to panacea's "If 0" switch. So yeah new Textures are working too.
PS: I hate KH1. I HATE IT!!!