Skip to content

load remastered assets for recom, ddd and kh1 etc. - #1307

Merged
Delta-473 merged 1 commit into
OpenKH:masterfrom
Kite2810:master
Nov 15, 2026
Merged

Delta-473 merged 1 commit into
OpenKH:masterfrom
Kite2810:master

Conversation

@Kite2810

Copy link
Copy Markdown
Contributor

Before panacea builded each remastered asset list from the games own list in the pkg and files in a mods remastered/file folder could then only replace certain entries that we are in that exactly that list. Textures or Assets with new names we're dropped. Which means custom models and textures did load, but got cut off the extra textures, simply because the offset did not longer matched the modded file.

So for Recom/DDD:
These now look up remastered textures/assets by the name and mod files replace originals with the same name too. So If sora has original 2 textures. The modded file can make now use of more than 2 textures for example, with custom names too.

For KH1:
the mod file with the original name replaces now the file and keeps it's original offset. The new file is added with it's offset taken from exactly that name.... A cvbl is matched by the name. From the base game... so it does get -1. the original file whose offset was taken by the new mod file is removed, so a rebuilded models hd textures, model, shadow, effect etc. lands on the new layout.

Added a debug log on what final asset is printed for each file :stare:

TESTED!!!

KH1 Sora completely replaced with a rebuild of an mdls with shortend Model Block, tighter packet etc. Loads fine, no Issues at all. Including the cvbl. Also tested DDD Kairi from pmo to mdls + cvbl, with a bone count of 109, 121 and 125. With keyblade bones and IK bones. Including the mset replacement to test a custom animation for each of these bone counts. Also tested on PS2 aswell. (by Napstio, thanks btw. for testing.) I kept myself under the Memory Limit too.

For RECOM/DDD I loaded my Custom Ventus and added more textures, to test where the new textures land exactly thanks to panacea's "If 0" switch. So yeah new Textures are working too.

PS: I hate KH1. I HATE IT!!!

Before panacea builded each remastered asset list from the games own list in the pkg and files in a mods remastered/file folder could then only replace certain entries that we are in that exactly that list. Textures or Assets with new names we're dropped. Which means custom models and textures did load, but got cut off the extra textures, simply because the offset did not longer matched the modded file.

So for Recom/DDD:
These now look up remastered textures/assets by the name and mod files replace originals with the same name too. So If sora has original 2 textures. The modded file can make now use of more than 2 textures for example, with custom names too.

For KH1:
the mod file with the original name replaces now the file and keeps it's original offset. The new file is added with it's offset taken from exactly that name.... A cvbl is matched by the name. From the base game... so it does get -1.
the original file whose offset was taken by the new mod file is removed, so a rebuilded models hd textures, model, shadow, effect etc. lands on the new layout.

Added a debug log on what final asset is printed for each file :stare:

TESTED!!!

KH1 Sora completely replaced with a rebuild of an mdls with shortend Model Block, tighter packet etc. Loads fine, no Issues at all. Including the cvbl. Also tested DDD Kairi from pmo to mdls + cvbl, with a bone count of 109, 121 and 125. With keyblade bones and IK bones. Including the mset replacement to test a custom animation for each of these bone counts. Also tested on PS2 aswell. (by Napstio, thanks btw. for testing.) I kept myself under the Memory Limit too.

For RECOM/DDD I loaded my Custom Ventus and added more textures, to test where the new textures land exactly thanks to panacea's "If 0" switch. So yeah new Textures are working too.

PS: I hate KH1. I HATE IT!!!
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 38262331-fa5a-44a4-a8f3-ac91ccda68f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@TopazTK

TopazTK commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

LGTM, based even.

@Delta-473 Delta-473 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Delta-473
Delta-473 merged commit 41ac7b5 into OpenKH:master Nov 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants