Conversation
The javadoc <link> to docs.groovy-lang.org/latest made every build download the Groovy element-list/package-list at javadoc time. The "latest" docs no longer serve package-list, so any transient miss on element-list failed attach-javadocs, which kept turning random build-maven matrix cells red. - Drop the link from the framework modules: none of them expose Groovy types in their public API. - In bundles-parent, replace it with an offlineLink backed by a committed package-list, pointing at the Groovy version the build actually uses (2.4.21) rather than "latest".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Scattered
build-mavenmatrix cells keep failing injavadoc:jar (attach-javadocs)withThe javadoc
<link>todocs.groovy-lang.org/latestmakes every build fetch the Groovy link list over the network. javadoc trieselement-listfirst and falls back topackage-list. Thelatestdocs now return 404 forpackage-list, so a single transient miss onelement-listfails the build. The same link has also been seen to hang javadoc until the 6-hour job limit. Recent examples are #130, #142 and #145, whose failed cells went green on a plain re-run.Change
OpenICF-java-framework/pom.xml: remove the Groovy link. None of the framework modules expose Groovy types in their public API, so the link added nothing there.OpenICF-java-framework/bundles-parent/pom.xml: replace both<links>blocks (pluginManagementand<reporting>) with anofflineLink. It points at a committedpackage-listunderbundles-parent/src/javadoc/groovy-2.4.21/. The URL now targets the Groovy version the build actually uses (2.4.21) instead oflatest, which currently holds the Groovy 5 docs. The connectors that expose Groovy types (groovy, ssh, kerberos) keep their cross-links.src/itinvoker projects, the plugin only logs an error and skips the link. It does not fail the build.groovyJavadocPackageListproperty says so.Verification
packagewithattach-javadocs(failOnWarnings=true) on JDK 26 forconnector-framework-contract,connector-framework-internal,groovy-connector,ssh-connectorandkerberos-connector, plusgroovy-connectoron JDK 11:BUILD SUCCESS.-Ddebug=true) has no network-linkleft. Groovy is passed as-linkoffline https://docs.groovy-lang.org/2.4.21/html/api <local dir>.docs.groovy-lang.org/2.4.21in 30 files for groovy-connector (e.g.groovy/lang/Closure.html,CompilerConfiguration.html), 6 for ssh and 4 for kerberos. No links tolatestremain.