apfpv: stop writing outgoing.enabled, which majestic no longer has - #158
Merged
Merged
Conversation
`outgoing.enabled` was one switch for the whole list of places a camera publishes to. Each destination has carried its own since OpenIPC/majestic#701, and the section switch was removed rather than kept as a second gate — so this line writes a key nothing reads. majestic strips it from the tree on load and the next save drops it from the file. The `.outgoing.server` line below it stays and is untouched: `cli` edits majestic.yaml directly, majestic converts that address into a row of its destination list on load, and the camera publishes exactly as before. There is no way to write a list element through yaml-cli — its path validator rejects the brackets — so the single-address spelling is the one this script must keep using.
openipc-ai
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
September 14, 2026 09:07
PR Summary by QodoStop APFPV customizer from writing obsolete outgoing.enabled
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can ask Qodo to dismiss a finding you disagree with, with your reason on record |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alongside OpenIPC/firmware#2418 which does the same for the four call sites there.
outgoing.enabledwas one switch for the whole list of places a camera publishes to. Each destination has carried its own in majestic's 2026-09 builds, and the section switch was removed rather than kept as a second gate — socli -s .outgoing.enabled truewrites a key nothing reads. majestic strips it on load and the next save drops it.clistores whatever dotted path it is given and exits 0, which is why this never complained.One line, in
devices/apfpv/general/overlay/usr/share/openipc/customizer.sh.The
.outgoing.serverline below it stays and is untouched.clieditsmajestic.yamldirectly throughyaml-cli, majestic converts that address into a row of its destination list on load, and the camera publishes exactly as before.yaml-clicannot write a list element — its path validator rejects the brackets — so the single-address spelling is the one this script must keep using, and majestic's 2026-09 builds keeps reading it for that reason.sh -nclean..github/scripts/lint-cli-paths.pyreports the same 5 pre-existing findings before and after this change, all of them$(cli -g …)captures in theopenipc/submodule.