Improve position warning context - #2188
Open
giovanni-br wants to merge 3 commits into
Open
giovanni-br wants to merge 3 commits into
giovanni-br wants to merge 3 commits into
Conversation
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
IAlibay
self-requested a review
September 16, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2159.
This PR makes the
set_and_check_new_positionswarning easier to understand.Previously, the warning only showed global atom indices, for example
mapping 0 : 4. This made it difficult to identify the affected atoms in areal system.
The warning now includes the old and new residue names, residue IDs, chain IDs,
and atom names, while keeping the global atom indices for debugging.
Example:
Tested with:
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes
Codex assisted with drafting the implementation and test update. I reviewed the
changes and ran the targeted test locally.
Checklist
newsentry, or the changes are not user-facing.Manual Tests: not run; this change only improves warning messages.
Developers certificate of origin