Skip to content

Explicit --checkout/--no-checkout beats OPENFN_NO_CHECKOUT_AFTER_DEPLOY - #1589

Merged
josephjclark merged 2 commits into
release/nextfrom
ofn-4763-checkout-flag-precedence
Oct 16, 2026
Merged

josephjclark merged 2 commits into
release/nextfrom
ofn-4763-checkout-flag-precedence

Conversation

@midigofrank

Copy link
Copy Markdown
Contributor

Short Description

An explicit --checkout or --no-checkout on project deploy now overrides OPENFN_NO_CHECKOUT_AFTER_DEPLOY. The env var only sets the default.

Fixes OFN-4763

Implementation Details

  • Root cause: checkout had a yargs default: true, so ensure() couldn't tell an explicit --checkout from the default and set checkout = false whenever the env var was 'true'.
  • Removed the yargs default; ensure() resolves the value from the env var only when the flag wasn't passed.

QA Notes

  • New deploy-options.test.ts (5 cases, parsing the real command through yargs): env=true + --checkout failed before the fix; the rest lock in existing behaviour.
  • --help no longer shows [default: true] for --checkout; the description still says checkout is the default.

AI Usage

  • I have used Claude Code
  • I have used another model
  • I have not used AI

@josephjclark
josephjclark force-pushed the ofn-4763-checkout-flag-precedence branch from 0914f9e to 51191c3 Compare October 15, 2026 15:31
@josephjclark
josephjclark merged commit 1f74134 into release/next Oct 16, 2026
10 of 11 checks passed
@josephjclark
josephjclark deleted the ofn-4763-checkout-flag-precedence branch October 16, 2026 11:24
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants