Repository navigation
fix: run on openadapt-types 0.19 through 0.21 - #352
Merged
Merged
Conversation
openadapt-types 0.18 made score() require the full RewardContractV1. assess_receipt holds only the expected contract digest and the certificate policy, so it now applies the same certification rules itself: tier 2 or 3, a current certificate, a certificate naming the expected contract when that digest is known, and the existing certificate-policy check. This fixes the 31 'score() missing contract' failures the monorepo preview found. Widen the pin to >=0.19.0,<0.22.0 (monorepo plan Q1). Signed-off-by: Richard Abrich <richard.abrich@mldsai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monorepo plan, phase 0 (R1/Q1): move evals onto the shared types line.
Why. openadapt-types 0.18 made
score()require the fullRewardContractV1.assess_receiptonly holds the expected contract digest and the certificate policy, so on 0.19 every call failed withscore() missing 1 required keyword-only argument: 'contract'(the 31 failures in OpenAdaptAI/OpenAdapt#1154).Change.
assess_receiptapplies the same certification rules directly: tier 2/3, certificate current at the trainer'spolicy_update, certificate names the expected contract when that digest is given (new, and stricter: matches what types'score()now refuses), plus the existing certificate-policy check.openadapt-types>=0.19.0,<0.22.0.uv.lock: the only version change is openadapt-types 0.17.0 -> 0.21.0; the rest of the diff is uv rewriting the lock in its current format (revision 3).Tests. The reward suites (verl, trl, certificate narrowing, proof) pass: 55/55. Full suite locally: 2874 passed, 13 failed, all in torch/TRL/VLM end-to-end tests (
test_trl_e2e,test_trl_robustness,test_vlm_wrapper) on my local all-extras environment, unrelated to reward. CI is the judge.Signed-off-by: Richard Abrich richard.abrich@mldsai.com