Repository navigation
ci(release): gate releases on a hosted Linux Xvfb lane - #166
Merged
Merged
Conversation
The release gate required live-qualification.yml on a self-hosted qualified Linux desktop. No such runner was ever registered, so no release could pass (1.3.0 release run 39075912841 failed closed). Replace that requirement with a GitHub-hosted ubuntu-latest job in production-qualification.yml. It runs three counted trials under Xvfb with X RECORD and XTEST, openbox, AT-SPI, and a focused GTK window: the structural observation test and the slow recorder and input tests, 8 tests per trial, no skips. The gate no longer proves more than one monitor, real input hardware, a compositor, or real window moves. live-qualification.yml keeps those lanes weekly and outside the gate. Signed-off-by: Richard Abrich <richard.abrich@mldsai.com>
Member
Author
|
Self-review before merge:
Signed-off-by: Richard Abrich richard.abrich@mldsai.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release gate (
scripts/check_release_ci.py) has required alive-qualification.ymlrun on a self-hosted, qualified Linux desktop since #132 (Sep 3). That runner was never registered.CAPTURE_SELF_HOSTED_QUALIFIED_LINUX_RUNNERSis unset, and the repo and org both have 0 runners. So no release could pass. The 1.3.0 release run 39075912841 failed closed on exactly this. Richard approved making the GitHub-hosted Ubuntu Xvfb lane the release gate.What changes
New job in
production-qualification.yml:Hosted Linux live qualification (ubuntu-latest, Xvfb). It installs the exact candidate wheel with[linux]into an isolated venv. Then, inside onedbus-run-session, it starts:RECORDandXTEST(both checked withxdpyinfo)at-spi-bus-launcherand openboxEntrywindow (relaunched for each trial)It runs three counted trials of
tests/test_structural_observation.pyandtests/test_performance.py -m slow, which is 8 tests per trial. That covers the recorder lifecycle, pynput→XTEST→X RECORD input capture, memory/CPU bounds, and AT-SPI structural observation. Each trial must passcheck_junit_no_skips.py --expected-tests 8, and thenaggregate_qualification_trials.py --expected-trials 3must pass. The evidence is uploaded as an artifact.check_release_ci.py: the new job joinsEXPECTED_QUALIFICATION_JOBS. Thelive-qualification.ymlrequirement and its Linux-job filtering are removed. Every release requirement now runs on GitHub-hosted runners.live-qualification.ymlis unchanged in behaviour. It still runs weekly on its schedule and on dispatch, but it is documented as outside the release gate.Tests,
release.ymlstep names,docs/DESIGN.md,docs/WINDOW_CAPTURE.md, and the v1.3.0 CHANGELOG are updated to match.What the gate no longer proves (honest scope)
The hosted lane is weaker than the self-hosted lane was meant to be. A release no longer proves:
--minimum-monitors 1.The weekly non-blocking
live-qualification.ymllanes remain the place for those, once a qualified desktop exists.Verification
run:block of the trial step from this YAML and ran it on a Debian 13 box with the 571d530 wheel. All 3 trials passed with 8 passed, 0 skipped each. Each trial passescheck_junit_no_skips.py --expected-tests 8, and the aggregate reportspassed: true. An earlier 1920x1080 screen exceeded the 500 MB memory bound intest_memory_bounded(511.6 MB), so the lane uses 1280x1024. The threshold is unchanged.uv run --extra dev pytest -q tests: 1036 passed, 22 skipped.ruff check openadapt_capture/is clean.scripts/check_changelog.pyis OK.Signed-off-by: Richard Abrich richard.abrich@mldsai.com