Repository navigation
fix(ci): set the commit release-package's plan step decides for - #1630
Merged
Merged
Conversation
The plan step ran release_plan.py with --tip "$RELEASE_COMMIT" but never set RELEASE_COMMIT, so under set -u every run past the Packages check failed with "RELEASE_COMMIT: unbound variable" (run 40809031545) and no package could publish. It is now github.sha, the commit the step's checkout holds. A test checks that every shell variable a step in the workflow reads is set by the job, the step, the runner or the script itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan step in
release-package.ymlrunsrelease_plan.py --tip "$RELEASE_COMMIT"underset -euo pipefail, butRELEASE_COMMITis set only in the laterpublish-githubsteps. Every run that gets past the Packages check fails before deciding anything: run 40809031545 stopped withRELEASE_COMMIT: unbound variable. Since #1606, no package can publish, including openadapt-flow 2.4.1 (#1620).Change
RELEASE_COMMIT: ${{ github.sha }}, the commit its checkout holds (main's tip for a workflow_run, schedule or dispatch run).tests/test_release_plan.pygains a test that every shell variable a step reads is set by the job, the step, the runner or the script. It fails on main with{'RELEASE_COMMIT'}and passes here.Checks
tests/test_release_plan.py,test_release_workflows_cache_free.pyandtest_newest_green.pypass (26 tests). ruff is clean.