[abrichr]

Replaces #1605 with one squashed commit on top of #1623 (which replaced #1592), so the secret scan no longer reads the old registry commits. Retarget to main once #1623 merges.

Review history:

• Review of Odoo new-contact: taught and read back, refused under clinical-write; shipped SQL is one read-only SELECT #1605 at 44c8ee5: Odoo new-contact: taught and read back, refused under clinical-write; shipped SQL is one read-only SELECT #1605 (comment)

Addressed:

• The shipped SQL read-back runs on a driver-level read-only session (PRAGMA query_only for sqlite3, set_session(readonly=True) for psycopg2, read_only for psycopg, SET SESSION TRANSACTION READ ONLY for the MySQL drivers). A shipped contract may name only those drivers, so pymssql is dropped.
• A shipped query must be SELECT <plain columns> FROM <tables>, with ::text/::varchar and AS allowed. Inputs may be bound only after WHERE, and the FROM part may not call functions. The review's four queries are now refusals in test_shipped_sql.py, along with a function in FROM and a query with no FROM.
• qualify.log and the fixture default no longer name a local scratch path. The README drops the VM notes and says only qualification/ is committed.

Not done here: narrowing the Odoo match key with create_date >= %(started_at)s. That's needed before this becomes a registry entry, and this PR adds none.

---

Stacked on #1592. This is the skills registry's first non-healthcare candidate: create a contact in Odoo 18 Community (LGPL-3.0). It runs on a local test copy holding synthetic data, with Odoo's images pulled by digest at run time.

What ran

• The fixture. benchmark/odoo_contacts brings up Odoo 18.0 and Postgres 16 on loopback, with a dedicated user and a read-only record-check role. It needed two fixes on its first run:
  • wait for Postgres before creating the database;
  • give the dedicated user Contact Creation, without which Odoo shows no save button.
• The demonstration (demo.py) chooses Individual, fills name, street, city, ZIP, phone and email, and saves. The contact is saved, and the record check reads all six fields back. The compiled program has 14 steps and 6 parameters (results/2026-10-28-click-teach/).
• Qualification under clinical-write refused before any case, as it should:
  • The City and Phone clicks are unarmed, because one-word labels are too little for an identity check. A keyboard path from checked clicks works, but it needs focus_on: check who has the focus after a key that changes nothing visible #1579's focus check.
  • The save button is an icon with no text. This is the same class as Medplum's Create button, which feat: arm a create-new form's save by the form the run typed into #1581 (form identity) addresses. Odoo's own save shortcut is Control+S on macOS and Alt+S elsewhere, so a taught shortcut isn't portable.

So no registry entry yet. Per #1598 the next step is the icon-button identity in #1581, not a page heuristic here. The details are in benchmark/odoo_contacts/README.md.

Shipped SQL is one read-only SELECT

As the coordinator decided, a public bundle may ship a minimal SQL record check: the typed fields, keyed by the identity field, on the app's documented schema. skills.shipped_sql_problems requires a single parameterized, read-only SELECT. It refuses:

• a second statement, comments, string literals and ${} text;
• writing, session, file and sleep functions, including INTO, FOR UPDATE, pg_*, lo_* and dblink;
• placeholders other than %(name)s, and any binding that isn't {param: ...}.

skill qualify checks it (inside shipped_contract_problems). So does the index build (build_registry_index.check_shipped_contract), so a bundle that breaks the rule never ships. The attest job's pinned wheels gain PyYAML for that check.

Tests

tests/test_shipped_sql.py: the Odoo SELECT passes, 11 kinds of unsafe query are refused, bindings must be typed inputs, the whole contract is checked, and the index build refuses a bundle whose SQL writes. These pass together with the registry suites (108 passed, 4 skipped without sigstore).

Also

• I merged main into focus_on: check who has the focus after a key that changes nothing visible #1579, whose CI had failed on two test_durable_authority_v13 tests. Main had already fixed them (b16d6cb). Auto-merge stays on.

🤖 Generated with Claude Code