Repository navigation
ci: link check passes PRs with no Markdown links; agent-guard e2e waits for the guard notice - #1575
Merged
Merged
Conversation
…or the guard notice Link check: a pull request whose changed Markdown holds no links made lychee fail with "No links were found" (failIfEmpty defaults to true). Main never hit it because pushes check every file. Agent guard e2e: a blocked save also fails the app's request, and its error could show before the guard's notice, so the simulated agent recorded "error" instead of "blocked" (intermittent on CI). It now keeps looking for the notice until its deadline before calling the save an error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
AI review (coordinator): approved. link-check: failIfEmpty false is correct (a PR whose changed Markdown has no links has nothing to check). agent_guard: the simulated agent keeps waiting for the guard notice until its deadline instead of reporting the app's save error first; fixes the race seen on #1530 and #1513. Benchmark harness only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two failures block unrelated PRs, #1530 among them.
lychee-actiondefaults tofailIfEmpty: true. Main never hits it: a push to main checks every file. The fix isfailIfEmpty: falseon the PR job.test_agent_guard_e2e(flow core critical) intermittently recordsscreen_after == "error"instead of"blocked". It failed on benchmark: freeze the independent verification spec and fault suite #1530 and on Production configuration soak: verified items per operator-minute, before and after (evidence) #1513's branch, and main passed. A blocked save also fails the app's request, and the app's#save-errorcan show before the guard injects its notice; the simulated agent (benchmark/agent_guard/agent.py) stopped at the first one it saw. It now keeps looking for the guard notice until its 4 s deadline, and calls the save an error only if no notice came.Not verified locally: the e2e can't run on this machine (an
mcpversion mismatch,call_tool() got an unexpected keyword argument 'validate_input'). The change is limited to the agent's observation loop. CI will exercise it.🤖 Generated with Claude Code