Repository navigation
fix(flow): keep record identity across the JSON baseline - #1482
Merged
Merged
Conversation
stable_id compared a record's raw id, or str() of each field. verify_run stores the pre-action baseline with model_dump(mode="json"), so a UUID, Decimal or datetime from a Postgres, MSSQL or Oracle driver came back as a string and no longer matched the live row. Every pre-existing row then counted as new, and count_new_only confirmed a write that never happened. stable_id now compares values in their JSON form (pydantic_core's to_jsonable_python, the same conversion the baseline uses), and leaves a value with no JSON form unchanged. Adds a Hypothesis round-trip over UUID, Decimal, datetime, date, int and text values. It fails on main and passes here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stable_id(runtime/effects/effect.py) identifies a record by its rawid, or bystr()of each field.verify_runstores the pre-action baseline withmodel_dump(mode="json"). Postgres, MSSQL and Oracle drivers return UUID, Decimal and datetime values, and those come back from JSON as strings, so they no longer equal the live row's values.As a result, every row that already existed counts as new, and a
count_new_onlyrecord check confirms a write that never happened. This is a silent fail-open. The realism audit found it (#1467, rank 6). The tests use SQLite ints and strings, so they never hit it.Fix
stable_idnow compares values in their JSON form, usingpydantic_core.to_jsonable_python, the same conversion the baseline goes through. A value with no JSON form, such as non-UTF-8 bytes, is left unchanged.Tests
tests/test_stable_id_json_baseline.py: a Hypothesis round trip over UUID, Decimal, datetime (aware and naive), date, int and text values, plus an unchanged UUID table that must show no new rows. These fail onmainand pass here.🤖 Generated with Claude Code