Repository navigation
fix(cli): the PATH version check never runs inside the check it starts - #1432
Merged
Merged
Conversation
`openadapt --version` asks any other openadapt on PATH for its version, and that one ran the same check, asking the first back. With two installs that both carry the check, they recursed without bound (a fork bomb, load ~900 on 2026-10-20). The child now runs with OPENADAPT_NO_LAUNCHER_CHECK=1, and the check returns at once when it is set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug, unreleased (#1408):
openadapt --versionruns<other openadapt> --versionto warn about a shadowing install. That child runs the same check and asks the first one back. With two installs that both have the check, they recurse forever, and processes orphaned by the 15 s timeout keep spawning more. On 2026-10-20 it fork-bombed a dev Mac to a load of about 900.Fix: the child runs with
OPENADAPT_NO_LAUNCHER_CHECK=1, and_warn_about_launcher_conflictsreturns at once when that's set. A new test covers both the guard on the child's environment and the early return. This has to land before launcher 1.18.0.🤖 Generated with Claude Code