Skip to content

Teach: a value typed once is lifted without a record-field check; short values collide #1474

Open

Description

@abrichr

jit/lift.py:164-171 lifts a single whole match without the _pick_repeated record-field check. record_sor._param_lookup binds every field equal to the input. With quantity="1" typed into refills, refills becomes the quantity parameter.

Proposed fix: apply the record-field check to single matches, and do not bind values under 3 characters (or bare numerics) by value alone.

Found by the realism audit (docs/audits/REALISM_AUDIT.md, #1467), rank 8.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions