Repository navigation
fix(admissions): clarify lookup errors and simplify form guidance - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the Ministry response
success: false, code: 419as an incorrect student number, including when it arrives with HTTP 200. Distinguish service, timeout, rate-limit and unavailable-certificate errors, clear input errors when details change, and keep raw provider messages out of the UI.Clarify guidance for other certificates and remove the explanatory sentence and icon beneath the admissions submit button in both languages.
Validation: 184 admissions tests and 15 lookup tests, production build, formatting, readiness/SEO checks and dependency audit passed. Arabic and English mobile browser checks covered the supplied error response, error recovery and the updated form. Provider error tests use synthetic responses.