Repository navigation
test(migrate): regenerate the instant_waits goldens for the never-firing call written as a ref action - #806
Merged
Merged
Conversation
…ing call written as a ref action Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
6 tasks done
HuiJun
marked this pull request as ready for review
October 2, 2026 01:40
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
go test ./tests/migratefails ondevelop(TestInstantBehaviorsWaitingForTheClockAreLedgeredandTestGoldenConstructFixtures): theinstant_waitsgoldens are stale. Two PRs that each passed CI on their own branch crossed:ref action call : Delay;and extends its ledger note with "…and it is written as a reference action usage, which the activity does not perform".instant_waits.golden.sysml/.golden.report.txtfrom a branch cut before feat(runtime): perform subactions no succession orders, unordered, during their owner #774 landed, so the goldens still carryaction call : Delay;and the shorter note.developruns no CI on push, so every PR mergingdevelopin now inherits the failure (seen on #757). This regenerates the two goldens with-update; the diff is exactly #774's intended output for theSend Ack Pausecall (_sapCall), nothing else moves:How it was verified
go test ./tests/migratepasses on this branch; onorigin/develop(9365f43) it fails with the two goldens differing by only the lines above.gofmt -l .prints nothing;python3 scripts/changelog.py checkpasses. No changelog fragment: test data only, and the behaviour it pins is feat(runtime): perform subactions no succession orders, unordered, during their owner #774's (already covered by its own fragment).Checklist
make testandmake lintpass locally (the failing package now passes; no source changed)changes/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.md(not needed, see above)make docs-countsrun if a gate count moved (no count moved)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/6133aceea157486ca9ebddf387b4959d
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/6133aceea157486ca9ebddf387b4959d?variant=devin
Requested by: @HuiJun