Skip to content

test(migrate): regenerate the instant_waits goldens for the never-firing call written as a ref action - #806

Merged
HuiJun merged 1 commit into
developfrom
fix/instant-waits-golden
Oct 2, 2026
Merged

HuiJun merged 1 commit into
developfrom
fix/instant-waits-golden

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

go test ./tests/migrate fails on develop (TestInstantBehaviorsWaitingForTheClockAreLedgered and TestGoldenConstructFixtures): the instant_waits goldens are stale. Two PRs that each passed CI on their own branch crossed:

develop runs no CI on push, so every PR merging develop in now inherits the failure (seen on #757). This regenerates the two goldens with -update; the diff is exactly #774's intended output for the Send Ack Pause call (_sapCall), nothing else moves:

-                action call : Delay;
+                ref action call : Delay;

How it was verified

Checklist

  • make test and make lint pass locally (the failing package now passes; no source changed)
  • Tests added or updated for the change
  • Documentation extended where it already covers the surface (none covers test data)
  • Changelog entry added as changes/unreleased/<slug>.<section>.md, not as an edit to CHANGELOG.md (not needed, see above)
  • baselines regenerated and make docs-counts run if a gate count moved (no count moved)
  • No internal work-item labels (waves, slices, F4, K5) in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/6133aceea157486ca9ebddf387b4959d
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/6133aceea157486ca9ebddf387b4959d?variant=devin
Requested by: @HuiJun

…ing call written as a ref action

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@HuiJun
HuiJun merged commit 7d955aa into develop Oct 2, 2026
24 checks passed
@HuiJun
HuiJun deleted the fix/instant-waits-golden branch October 2, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant