chore(editors): lock the editor versions to the core version - #745
Merged
Merged
Conversation
The editors carry the core version the clients already follow: 0.9.0 in the two package.json files (locks regenerated, only the version lines move), the Cameo and SysON poms, and the child poms' <parent><version>. Nothing publishes the editors, but check_version.py --editors now reads every editor manifest - package.json, package-lock.json (both version copies must agree), pom and child <parent><version> - through the shared lockstep check, so a release tag fails early when one disagrees. The python changed-area trigger covers every editor manifest, build-python-package runs --editors before anything is built, and releasing.md's bump step lists the files. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Merged
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The clients now release at the core version (
_version.py), but the editors still carried0.1.0and0.1.0-SNAPSHOT. This PR moves them into the same lockstep. Ondevelopthey now read0.9.0, and the release branch bumps them with everything else.Versions set to
0.9.0:"version"ineditors/vscode/package.jsonandeditors/syson/frontend/package.json. Both locks were regenerated withnpm install --package-lock-only, and only the rootversion/packages[""].versionchanged.<version>ineditors/cameo/pom.xmlandeditors/syson/pom.xml.<parent><version>in the six child poms (cameo/{plugin,tools,openapi-stubs,dist},syson/{backend,syson-api-stubs}).check_version.py --editors: runs every entry ofEDITOR_MANIFESTSthrough the shared_client_versioncheck, against_version.pyand the tag when one is given. It uses four readers:json: package.jsonversionlock: the top-levelversionandpackages[""].version, which must also agree with each otherpom: the pom's own<version>parent:<parent><version>build-python-packagecalls it next to--node/--java/--rust, so a tag fails before anything is built when an editor disagrees. Nothing publishes the editors, so no version is exported.scripts/ci-changed-areas.sh: the Python trigger now covers every editor manifest, so a PR that changes only one of them still runs the lockstep tests. The existingvscode-onlycase inci-changed-areas-test.shexpectedvscodealone foreditors/vscode/package.json. That expectation is nowpython,vscode(renamedvscode-manifest), because that file now triggers the Python suite by design. Six new cases were added alongside it.Docs:
releasing.md: the release-branch bump step lists every editor manifest, and the tag section and the Java "The version" section mention the editors.editors/README.md: new Versions section.nightly.md: the vsix example version changes from0.1.0-nightly-…to0.9.0-nightly-….This replaces #744, which documented the opposite choice (editors versioned on their own).
How it was verified
pytest tests/test_check_version.py: 80 passed (9 new). The new tests cover:--editorstogether with--nodebeing refusedbash scripts/ci-changed-areas-test.sh: all cases pass.check_version.py --tag v0.9.0 --editorsprints0.9.0.mvn -B -q -N validateand full-reactorvalidatesucceed foreditors/cameo/pom.xmlandeditors/syson/pom.xml, so the child<parent>versions resolve.npm ci --ignore-scriptssucceeds ineditors/vscodeandeditors/syson/frontend, so the locks match.circleci config validate,python3 scripts/changelog.py check,make docs-checkandpython3 scripts/check-doc-links.py(0 broken) all pass.Checklist
make testandmake lintpass locally (n/a: no Go change; the Python and editor gates above were run)changes/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (n/a)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/50e350d0913749039440892f390a0f90
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/50e350d0913749039440892f390a0f90?variant=devin
Requested by: @HuiJun