300 Update sh_template so that MacOS can support wxWidgets - #301
Merged
OneLoneCoder merged 1 commit intoSep 19, 2026
Merged
OneLoneCoder merged 1 commit into
OneLoneCoder merged 1 commit into
Conversation
Also updated project paths to use relative paths
Collaborator
Author
|
and finally but most important Windows working as expected: |
Johnnyg63
deleted the
300-update-sh_template-so-that-macos-can-support-wxwidgets
branch
September 20, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To correct this issue we have move the api_macos_wrapper.hpp, api_macos.h/cpp code out of the OLC_USE_WXWIDGETS condintional statement and gaurded them with OLC_HOST_MACOS set. This will ensure Imageloader_macos and any other C++ requiring access to the wrapper can still excute as expected regardless if OLC_USE_WXWIDGETS is set or not.
Athought the main change was just a short movement of macro gaurds, please see sh_template.h below, it does cause a large change in the SH, the is because we have moved the macos Wrapper code up by approx 1000 lines and via versa for the cpp codes.
Therefore I have tested the SH again for, Windows, Macos, XCode, VS Code (yes using CMake... ), wxWidgets.
Evidance:
VSCode:
wxWidget MacOS
iOS (Aphla testing only) wxWigdets and PGE3 iOS
Screen Recording 2026-09-15 at 20.09.27
...
And windows... give me 5 mins to get the screen caps