Repository navigation
feat(navigator): show the player count per mode - #417
Merged
Merged
Conversation
Contributor
Test results 894 files 894 suites 41m 38s ⏱️ Results for commit 2100dcd. ♻️ This comment has been updated with latest results. |
Each navigator entry gets a lore line with the players currently on its CloudNet task, read through the existing PlayerCounts bean and refreshed every navigator.refreshSeconds (default 5). Unknown counts add no line. Claude-Session: https://claude.ai/code/session_01GXose9rakuRNZoM3TP3xj1
TheMeinerLP
force-pushed
the
feat/navigator-player-counts
branch
from
October 12, 2026 19:27
2994648 to
2100dcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every navigator entry now shows
N onlineas a lore line: the players currently on that mode's CloudNet task, summed over its running services.PlayerCountsbean (count(TASK, name), whichHolderPlayerCountssums over running services). Injected asOptional<PlayerCounts>, so the navigator still works without a provider.navigator.refreshSeconds(newnavigator.yaml, default 5, validated 1..3600 likelobbyswitcher.refreshSeconds). The read runs on a virtual thread, skipped while the previous one is running; the stacks are updated in place on the next tick, for both the public and the team inventory. The task is cancelled in@PreDestroy.0 online.applyLayoutIfChanged) and click handling are unchanged; rebuilt layouts reuse the last known counts.io.avaje.configin the navigator now allows it forNavigatorSettingsonly.Tests
Unit tests for the lore (known/zero/unknown),
TaskPlayersand the settings; MinestomEnvtests with a fakePlayerCountsthat drive the refresh with explicit ticks (first read, update after one period, unknown, stop, click still works).https://claude.ai/code/session_01GXose9rakuRNZoM3TP3xj1