Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The fixed dependency policy, compatibility matrix, tests, and documentation consistently satisfy the stated requirements.
Pull request overview
Makes ESAPI dependency selection deterministic while documenting and validating compatibility and security expectations.
Changes:
- Pins ESAPI to 2.7.0.0 with an explicit override.
- Adds dependency convergence enforcement and CI coverage for ten stable releases.
- Expands adapter runtime tests and documents security implications.
File summaries
| File | Description |
|---|---|
README.md |
Links the ESAPI dependency policy. |
esapi/README.md |
Documents compatibility, security, and JPMS policies. |
esapi/pom.xml |
Pins ESAPI and enforces dependency convergence. |
.github/workflows/build.yaml |
Adds the ESAPI compatibility matrix. |
esapi/src/test/resources/.esapi/ESAPI.properties |
Provides cross-version test configuration. |
esapi/src/test/java/org/owasp/encoder/esapi/ESAPIEncoderTest.java |
Expands runtime compatibility coverage. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The published
encoder-esapiPOM currently uses[2.5.1.0,3). A fresh build now resolves that range to2.7.0.1-RC1, allowing repository contents and downstream dependency selection to change without a commit.What changed
esapi.versiondefault of2.7.0.0, the current upstream-supported stable release-Desapi.version=...maintainer overrideencodeForSQLsafety policyesapi, coordinating with Fix JPMS dependency reads in the JSP, Jakarta, and ESAPI adapters #92 / Fix JPMS dependency reads in adapter modules #98Security and runtime review
ESAPI 2.7.0.0 fixes CVE-2025-5878 and updates dependencies for CVE-2025-48976 and CVE-2025-48734. The 2026-09-11 graph review also found later advisories in ESAPI legacy Commons dependencies and HTTP Components brought through AntiSamy. The adapter does not force untested transitive upgrades; the new policy document records affected components, patched versions where available, and the need for application-level assessment.
Only ESAPI 2.7.0.0 is upstream security-supported. The earlier versions are retained solely as an adapter compatibility claim and migration safety net.
Validation
mvn -B -ntp clean verify— 1,151 tests, no failures/errors/skipsclean installselected ESAPI 2.7.0.0esapigit diff --checkpassedFixes #94