Modernize build, CI, packaging, and documentation - #90
Merged
Merged
Conversation
melloware
approved these changes
Sep 11, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spring-coredependency paths reported for GHSA-659m-px2c-25wjReview fixes
Automatic-Module-Namevalues (org.owasp.encoder,org.owasp.encoder.jsp,org.owasp.encoder.jakarta, andorg.owasp.encoder.esapi). Keep these manifest names independent of the unchanged explicit JPMS descriptors (owasp.encoder...), retain the legacyjigsaw.module.nameMaven configuration property, and document the distinction._noimportjavainstruction. All four published bundles now omit thejava.*imports that older frameworks reject.Validation
mvn -B -ntp clean verifywith Homebrew OpenJDK 17 and Maven 3.9.16: 1,147 tests passed with no failures, errors, or skips.Importing java.* packages not allowed: java.io, then passes with the fix.31588e1:mvn -B -ntp install -PtestJakartaran all 1,149 tests, including module-metadata regression tests, OSGi compatibility, and the Docker/Selenium browser test, with no failures, errors, or skips.actionlint .github/workflows/build.yaml, XML validation for every POM andsrc/site/site.xml, and whitespace checks respecting the existing CRLF convention incore/pom.xml.Follow-ups intentionally left out
mvn sitestill fails in the legacy Maven Site 3.4/Reflow/Doxia stack. Sincegh-pagesis only a redirect to the OWASP project page, retiring that machinery may be preferable to upgrading it.