some performance improvements

[superwhiskers]

this pull request provides some performance improvements that target larger cases, like activsg10k.

as a quick, unscientific check,

• application/PhasorDynamics/DynamicSimulation on ACTIVSg10k completes in 24.3332 seconds using these changes
• application/PhasorDynamics/DynamicSimulation on ACTIVSg10k completes in 51.6972 seconds as of 9330ee88

both builds were a standard release (RelWithDebInfo) build

Checklist

• All tests pass.
• Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
• The new code follows GridKit™ style guidelines.
• There are unit tests for the new code.
• The new code is documented.
• The feature branch is rebased with respect to the target branch.
• N/A The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

[pelesh]

Fails to build with following error message:

[ 75%] Building CXX object tests/UnitTests/PhasorDynamics/CMakeFiles/test_phasor_governor_tgov1.dir/runGovernorTgov1Tests.cpp.o
Undefined symbols for architecture arm64:
  "void GridKit::LinearAlgebra::detail::logBoundsCheckFailure<unsigned long>(unsigned long, unsigned long)", referenced from:
      GridKit::Testing::VectorTests<double, unsigned long>::setToConst(unsigned long) in runVectorTests.cpp.o
      GridKit::Testing::VectorTests<double, unsigned long>::setToConst(unsigned long) in runVectorTests.cpp.o
      GridKit::Testing::VectorTests<double, unsigned long>::setToConst(unsigned long) in runVectorTests.cpp.o
      GridKit::Testing::VectorTests<double, unsigned long>::setToConst(unsigned long) in runVectorTests.cpp.o
      GridKit::Testing::VectorTests<double, unsigned long>::setToConst(unsigned long) in runVectorTests.cpp.o
      GridKit::Testing::VectorTests<double, unsigned long>::setToConst(unsigned long) in runVectorTests.cpp.o
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [tests/UnitTests/LinearAlgebra/Vector/test_vector] Error 1
make[1]: *** [tests/UnitTests/LinearAlgebra/Vector/CMakeFiles/test_vector.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 75%] Built target test_vector_handler
[ 75%] Built target test_math_smoothness_indicator
[ 75%] Built target test_phasor_bus
[ 75%] Built target phasor_dynamics_gensal_dependency_tracking
[ 75%] Linking CXX executable test_phasor_bus_fault
[ 75%] Built target test_phasor_bus_fault

[pelesh]

Same error with a clean build from scratch.

[pelesh]

Looks good. Some nitpicking comments to consider.

[pelesh]

10k system validation time is reduced from 26.9s to 20.4s on my machine.

[pelesh]

Unit tests for the vector class all pass.

[nkoukpaizan]

Thanks for looking into this!

10K solution time dropped from ~60s to ~45 on Frontier (single thread CPU). Performance on my MacOS did not change significantly (~30s). I suspect different default inlining behaviors. This is overall a net benefit.

@superwhiskers I recommend updating the PR description to reflect the final speedups you saw on your end.

[nkoukpaizan]

If we are removing these, there should be one more in TgovEnzymeDependencyTracking.cpp for "Jacobian evaluation is experimental!".

Could you comment on motivation for removing all of them? We don't really need them anymore, but the \n versions should not significantly impact performance. Also see #512 (out of scope for this PR).

[superwhiskers]

it's something i thought i'd try and while it didn't influence anything, i thought i'd leave it in because it seemed unnecessary

[lukelowry]

Faster=happier

Thank you good work