Repository navigation
[19.0][FIX] project_hr: allow portal users to open shared tasks - #1876
Merged
Merged
Conversation
domain_user_ids is needed by the project sharing task form, but it was not portal readable and its compute read hr categories without sudo.
Contributor
|
Hi @pedrobaeza, |
pedrobaeza
approved these changes
Nov 6, 2026
Member
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at c2f4b52. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project sharing task form shows
user_ids, whose domain depends ondomain_user_ids. In 19.0, reading a field outsideTASK_PORTAL_READABLE_FIELDSraisesAccessError, so portal users can't open shared tasks.This makes
domain_user_idsportal readable and computes it withcompute_sudo=True, asdomain_hr_category_idsalready does, because the compute reads hr categories. A portal test is added.@ForgeFlow