Skip to content

[19.0][FIX] document_page(_approval): forward ports from 18.0 - #659

Open
MiquelRForgeFlow wants to merge 3 commits into
OCA:19.0from
ForgeFlow:19.0-fw-port-18.0-fixes
Open

MiquelRForgeFlow wants to merge 3 commits into
OCA:19.0from
ForgeFlow:19.0-fw-port-18.0-fixes

Conversation

victoralmau and others added 2 commits October 30, 2026 11:14
…ry and send mail

Example use case:
- Modify the Odoo Features category, check Require approval, and set Approver group > Administration / Access Rights
- Modify the Marc Demo user and define Document Knowledge > Editor permissions
- Go to the Odoo Features category and, taking into account the ID, delete the mail_message record table with the same ID from the database
- With the Marc Demo user, go to the Knowledge > Odoo Features menu and enter the Odoo 15.0 Functional Demo page (it is important to follow these specific steps)
- Modify the page and save

Before this change, an error could occur because the action https://github.com/OCA/knowledge/blob/0881d75a35e7fc2f814110df4878177e805e589b/document_page/views/document_page_category. xml#L83C17-L83C42 defined a default_parent_id=x (page category ID) if there was no mail_message linked to that category ID; now the value of default_parent_id is removed to avoid this specific error.

TT61290
@oca-cla-bot

oca-cla-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@OCA-git-bot OCA-git-bot added mod:document_page Module document_page series:19.0 mod:document_page_approval Module document_page_approval labels Oct 30, 2026
@MiquelRForgeFlow MiquelRForgeFlow changed the title [19.0] document_page(_approval): forward ports from 18.0 [19.0][FIX] document_page(_approval): forward ports from 18.0 Oct 30, 2026
@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

@astirpe @jans23 could you check CLA?

@astirpe

astirpe commented Oct 30, 2026

Copy link
Copy Markdown
Member

Hi @MiquelRForgeFlow , could you please change the author of the last commit to my work email? You can run:

git checkout 19.0-fw-port-18.0-fixes
git commit --amend --no-edit --author="Andrea Stirpe <ast@360erp.com>"
git push --force

@astirpe astirpe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiquelRForgeFlow thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:document_page_approval Module document_page_approval mod:document_page Module document_page series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants