[sunzenshen]

ntre_dusk_ctg: navmesh rework

One file, neo/maps/nav/ntre_dusk_ctg.nav. It was measured on upstream master plus the draft NeotokyoRebuild/neo#2176 (then only its unwanted-ladder release, now its changes 1 and 7) and NeotokyoRebuild/neo#2186 ("Bots skip weapons they cannot reach", merged since), with harness logging added; the final file was measured again on the harness's research build of the bot code (those PRs plus the other open bot code PRs, among them NeotokyoRebuild/neo#2197). ntre_dawn_ctg has the same layout and gets the same mesh in its own PR (#151).

Dependencies and status

Needs (worse than master, or broken, without it):

• None. No open bot code PR has to be reviewed or merged before this mesh: the mesh measures better than master with and without More tweaks to bot ladder approaches, climbs and dismounts neo#2176 (see "How it was tested"). The parked rabbitfrog vehicle is handled in the mesh (see "Review fixes").

Helped by (measured better with it; the mesh does not wait on it):

• Bots detour around physics/animation props neo#2197 ("Bots detour around physics/animation props", ready for review): the two office chairs, which move and so are not cut out of the mesh.
• More tweaks to bot ladder approaches, climbs and dismounts neo#2176 ("Fix bot ladder approaches, climbs and dismounts", draft): ladders 1, 2 and 4. In its ladder tests on this mesh (12 bots, a team sent up one ladder, three runs), climbs up ladder 4 finished 18 of 18 (master 10 of 16), up ladder 2 22 of 22 (master 10 of 20, 8 of them falling from the top), and up ladder 1, the 7 u wall cap, 9 of 15 (master 0 of 1). In matches on this map and ntre_dawn_ctg, its dismount change cut ladder 4 climbs kicked backwards off the top from 71 of 627 to 4 of 604 (see "Known, not changed").

Pending before review:

• Nothing: ready for review.

At a glance

	master	this PR
nav areas	1358	1099
file size	1,168,376 bytes	772,996 bytes (-34 %)
areas the engine blocks at every round start	28	2
areas no spawn can reach	58 in 20 pockets	20 in 7 pockets (see below)
nav ladders	4	4; ladder 1 now leads somewhere (see "Ladder 1")
bot stuck events a match, 1 round (see below)	5.65	1.85
bot stuck events a match, 2 rounds, before the 116 step cut	38.6	14.9

Six commits:

1. Rework - the mesh itself.
2. Id alignment with master - ids only, so an id-keyed diff against master reads sensibly.
3. Review fixes - one-way walk links, the area under the rabbitfrog vehicle and climbs no bot makes, from an outside review (section 3).
4. Blocked links - drop backs restored, and areas no player hull fits in removed, from the engine's hull audit of commit 3 (section 3).
5. The bamboo pocket - a drop no player can make cut, and the pocket's way out moved onto the lane a player fits through (section 3, last part).
6. The 116 step - 116 -> 1165, a walk link down a ~27 u displacement step, cut one way (116 still reaches 1165 through 4380 and 4159; 1165 -> 116 stays). A bot spawned on 116 walked off at 1165's west edge and wedged with no ground under it. Twin runs at the ghost pins that spawn bots on 116, with the research build's wedge escape (a bot code experiment that hops a wedged bot free) switched off, 18 runs a mesh on both maps (12 on this one): wedges 2 -> 0, both on this map.

1. What changed

• Sliver areas merged into their neighbors on the same floor, and areas the engine blocks at round start (a prop or brush over their center) cut away. On master the engine blocks 28 areas at every round start; here 2.
• The garden wall (the wall with the ivy ladder, south of the walkway near (240..500, 4630)). On master it was the largest stuck spot: 11.1 stuck events a match, 1.3 bot episodes a round. Bots on the walkway took the drop to the garden through the wall's west end (603 -> 601) or jumped at the wall's 8 u cap, and pressed into the wall. Both are cut; the garden is reached round the wall or by ladder 1. Here: 0.
• Walk links a player hull cannot cross are cut: past the feet of the rabbitfrog vehicle near (2050,3900) (a helicopter that lands at round start and stays parked; see "Known, not changed"), between bamboo stalks near (1935,3525) and (450,1540), and through the bamboo row near (1650,4160), which is now crossed at its east end, with the areas beside it a half hull off the stalks.
• Ladder 1 (see below).
• Pockets: a 13 x 12 u sliver near (430,1555) that bots could walk into but not out of gets a return link; a box top no spawn reaches, with no way out, and an isolated area under props are removed.
• The 116 step near (2176,4300): the walk link 116 -> 1165 down a ~27 u displacement step is cut one way. Paths from 116 entered 1165, a 25 u strip, at its west edge, over the steepest part of the step, where a bot can wedge with no ground under it. 116 still reaches 1165 through 4380 and 4159, and 1165 -> 116 stays.
• Re-analyzed in game after the edits, so the per-area visibility lists bots use for what they can see are current.

2. Id alignment

1117 of the 1123 areas carry the id of the master area they match, including the wall cap at ladder 1's top (4424). All four ladders keep their ids. Areas are matched only within 64 u of height. Geometry, connections, attributes and the analysis data are unchanged by this step (verified topology-identical).

3. Review fixes

• One-way walk links. The pass that cut walk links over railings and props cut one direction of some pairs and kept the other, so a bot following the kept direction walked into the same obstacle. Each pair was swept by the engine with a player hull in both directions:
  • blocked both ways, now cut both ways: seven pairs, at the rabbitfrog vehicle near (2000,3925) (3), at bamboo stalks near (1550,3880) and (1935,3535) (3) and at a work light near (1875,4210) (1)
  • clear both ways, the missing direction restored: six pairs, among them two narrow ones, beside the rabbitfrog (4152 / 691) and between bamboo stalks near (2260,4000) (3859 / 3858); two of the six (4127 and 4128 to 455, near (840,2400)) were one-way on master
• The area under the rabbitfrog vehicle (694, near (2050,3900)) is deleted. Once it has landed, the vehicle stands on it for the rest of the round: the engine's hull test finds no room to stand on 287 of its 325 sample points. The areas round it were already joined to each other.
• Climbs no bot makes. The 10 u wall cap near (30,4560) (4382) could only be reached by a 92 u climb from the ground below it; it is deleted with its climb. The 70 u climb onto the roof of the APC near (-2240,2860) (1386) is above every class's limit (a Recon plans climbs under 68 u) and is removed; the roof stays as a pocket bots can drop from, like the others.
• Every other area keeps its id and geometry.
• Blocked links (commit 4). The engine's hull audit of commit 3 (a player hull stood on every area and swept across every link, in the server), and a link check against master:
  • six climbs of 19-38 u had lost their drop back; the climb reads clear on some or every lane, so the drop back is restored. One of them drops off a crouch strip on a concrete barrier near (-2150,2825) onto an area bots reach on the level and never visited in 100 matches; the audit sweeps a crouched hull there, so it was checked in the matches below
  • areas no player hull stands in (89-100 % of stand samples blocked, seldom or never visited) are deleted: 12 x 12 to 25 x 25 u squares inside bamboo clumps, a street lamp, a temple lantern, a wooden wall, a desk, wall corners, a work light
  • 4143, beside the rabbitfrog vehicle near (1975,3910), is deleted: the parked vehicle blocks 224 of its 247 stand samples. The areas round the vehicle keep their other links
  • three pairs blocked both ways that bots never cross are cut both ways (bamboo)
  • kept, bots cross them: a bamboo row near (2250,4245), the work truck near (-1600,3262), a displacement slope and a work light bots walk past; left as they stand at map load, for the bot code's runtime prop avoidance: the office chairs near (-812,925) and the breakable glass near (-650,1700)
• The bamboo pocket (commit 5). A pocket under a 60 u ledge near (250,1830), beside a bamboo clump (a static prop), had two drops into it. Over the east one (into 2518) a stalk of the clump overhangs the space a player falls through, so the bots' path code finds no clear spot to drop and puts the landing 70 u past the ledge, beyond the clump. Bots took that drop, landed against the stalks and kept pushing toward the landing: 22 of the 26 stuck episodes at the pocket in 400 matches on commit 4 (both maps) started there, the other 4 at its way out (below).
  • that drop and the climb back up are cut: the engine's hull test reads both blocked on every lane, and no bot made either as planned. The pocket is still reached by the west drop (into 2506) and from the ground east of it (211)
  • the pocket's way out (2506 -> 2518 -> 211) is moved 9 u north, onto the 10 u lane where a player hull fits between the ledge wall and the stalks: the path crossed from 2506 to 2518 at a point no hull can stand on. 2506 keeps its south part, where bots landing from the drop end up. The hull test now reads 2506 -> 2518 -> 211 clear on every lane (1 of 5 before)

Ladder 1

Ladder 1 is the ivy wall on the garden's north side, (262..489, 4611..4623), from the garden floor (z -251) to the wall's 8 u wide cap (z -160); the walkway north of the wall is 45-50 u below the cap. On master the nav ladder covered only the top 42 % of the climb, and its top joined the cap both ways to the walkway. On the branch this mesh came from, the cap had no walk links at all, so the ladder led nowhere.

• The ladder's bottom is on the garden floor, at the area in the gap between the two benches at its foot.
• The cap drops to the walkway north of the wall (master's exits).
• The jumps from the walkway up onto the cap stay cut, so the ladder is a climb route. With them restored as on master, the ladder could also be taken down, but in 60 test matches with that version no bot did, and stuck events were x1.23 of this PR's in both comparisons ([0.90, 1.69] and [0.86, 1.85], pooled with dawn).

Bots climbed it 19 times in 20 matches (dawn: 16 in 20); of the 57 climbs on both maps and both versions, 52 reached the walkway within 8 s. No stuck event on any area around the wall or the ladder.

How it was tested

• Reachability:

  • every spawn can reach every other spawn
  • every objective is reachable
  • 20 areas no spawn can reach, in 7 pockets, all of which lead back into the mesh: roof and ledge pockets bots can only drop from (master has 58 in 20 pockets)
  • no area that can be entered and not left, for any class, counting only the climbs each class plans (Recon under 68 u, Assault 48 u, Support 43 u), and no area reached only by a climb above those limits
  • no walk link between two areas at the same level runs one way, and no climb a class plans lacks its drop back, except the step up from 1165 to 116, whose way down is the cut above (section 1)
  • the engine hull audit of this mesh: of 1843 pairs of areas at the same height, the few read blocked both ways are the kept links above, the office chairs and the glass (BLOCKED_LINKS map=ntre_dusk_ctg level_pairs=1843 oneway=0 keep=0 cut=1 area=2 check=2 entity=4)
  • the engine blocks 2 areas at every round start (master: 28): two crawl areas under the wooden bridge near (-25,4430); the crawl stays open through the three areas beside them, and master blocks one of the two as well

• Falls. The map has no trigger_hurt and no other hurt volume, and no drop that kills a bot at full health (the deepest drop link is 233 u, 2 damage). No fall marks were needed.

• Master against the final file, 1 round. The same twin setup and stuck count as below, on the harness's research build of the bot code: CTG, 1 round with the ghost pinned at each of the 5 ghost spawns, 4 runs each, 30 bots, default weapon damage, the game's default 15 s freeze time, 8 matches at a time, the arms interleaved. Rates a match are about half those of the 2-round runs below. All 40 matches reached match end with 0 asserts and no crash.

  • stuck events 5.65 -> 1.85 a match (paired x0.38, 95 % interval [0.25, 0.59], 13 of 20 pairs down, 2 up); bot episodes 1.85 -> 0.75 a match
  • FAIL_NO_PATH_EXISTS move failures 0.60 -> 0.80 a match (x1.07 [0.76, 1.56]); "fell off the path" failures 0.80 -> 1.10 (x1.20 [0.83, 1.68])
  • kills 24.3 -> 25.5 a match (x1.05 [1.01, 1.09]); ghost captures 1 -> 2 of 20 rounds; no fall deaths
  • at the spots: the garden wall 4.1 stuck events a match -> 0; the bamboo pocket 2 stuck events and 4 FAIL_NO_PATH_EXISTS move failures in 20 matches -> 0; at the 116 step no event of any kind on either mesh (bots stood on 1165 in 7 of 20 matches, master 12, and on 116 in all 20)

• Master against this mesh before the 116 step cut, 2 rounds, same bot code. Byte-identical copies of the map, one carrying each .nav, run back to back. CTG, 2 rounds of 3 minutes with the ghost pinned at each of the 5 ghost spawns in turn, 4 runs each, 30 bots, default weapon damage, 8 matches at a time. Every match reached match end with 0 asserts and no crash (368 matches on dusk and dawn in all, probes and the other revisions included). The stuck count is OnStuck plus FAIL_STUCK move failures, excluding the spawn crush at round start and the weapon-scavenging behavior.

  • stuck events 38.6 -> 14.9 a match (paired x0.32, 95 % interval [0.19, 0.48], 20 of 20 pairs down)
  • without #2176 (the unwanted-ladder release switched off in both arms, so upstream ladder code; 2 runs a spawn): 40.3 -> 21.0 (x0.56 [0.37, 0.91], 8 of 10 pairs down, 2 up)
  • FAIL_NO_PATH_EXISTS move failures 3.9 -> 5.2 a match, paired x1.26 [0.90, 1.78] (without #2176 7.9 -> 4.3); "fell off the path" failures 0.6 -> 0.5
  • kills 49.0 -> 49.1 a match (x1.01 [0.97, 1.04]); ghost captures 7 of 56 rounds -> 6 of 53 (over both maps and both comparisons 17 of 166 -> 17 of 165); team kill ratio (Jinrai / NSF enemy kills) 0.97 -> 1.08; deaths to the world (fall damage on low health) 2 -> 1 in 20 matches
  • bots still see and shoot across the mesh: 94 % of kills are between bots in different nav areas (master 95 %), 82 % in non-adjacent areas (master 86 %); median kill distance 412 u (master 419 u)
  • at the spots: the garden wall 11.1 stuck events a match -> 0; the dead-end room near (775,940) 4.5 -> 2.2; ladder 4's top 1.4 -> 2.4 (0.16 -> 0.15 bot episodes a round)

• The review fixes (section 3) against the previous revision of this PR, one comparison. The same twin setup with the previous and the fixed .nav, the ghost pinned at each of the 5 ghost spawns, 10 matches each, 30 bots, default weapon damage, 8 matches at a time, on the same bot code as above:

  • stuck events 15.8 -> 17.1 a match (paired x1.14, 95 % interval [0.84, 1.54], 22 of 50 pairs down, 27 up). The rises are at three spots listed under "Known, not changed" below, none near an edit (the office chairs, the dead-end room and ladder 4's top, which swing from match to match); without them, 9.9 -> 8.5 (x0.90 [0.63, 1.28])
  • stuck events at the ends of the edited links and around the rabbitfrog vehicle 10 -> 6 in 50 matches (on ntre_dawn_ctg, 326 -> 4: bots trapped under the vehicle in 3 of 50 matches, up to 156 stuck events in one). Those traps came from the test harness's 2 s freeze time: the bots walked under the vehicle while it was still landing (see "Known, not changed")
  • FAIL_NO_PATH_EXISTS move failures 6.1 -> 6.2 a match; "fell off the path" 0.5 -> 0.6; kills 48.4 -> 48.7 a match; ghost captures 8 -> 8 of 100 rounds; 94 / 93 % of kills between different nav areas and 82 % between non-adjacent ones
  • no fall deaths, no asserts, no crashes in 100 matches

• Commit 4 against commit 3, one comparison. The same twin setup, the ghost pinned at each of the 5 ghost spawns, 5 matches each, 30 bots, default weapon damage, 8 matches at a time, on the same bot code:

  • stuck events 16.9 -> 15.0 a match (paired x1.04, 95 % interval [0.65, 1.75], 14 of 25 pairs down, 11 up); without the three spots under "Known, not changed", x0.84 [0.46, 1.56]
  • stuck events at the edited links and areas 18 -> 16 in 25 matches; in the gap under the rabbitfrog vehicle 0 -> 1
  • FAIL_NO_PATH_EXISTS move failures 6.0 -> 4.3 a match; "fell off the path" 0.9 -> 0.5; kills 48.4 -> 48.7 a match; ghost captures 2 -> 5 of 50 rounds; 94 / 95 % of kills between different nav areas and 81 / 82 % between non-adjacent ones; deaths to the world 2 -> 1, all in the office chairs' corridor (no drop there)
  • no asserts, no crashes in 50 matches

• Commit 5 against commit 4, two comparisons pooled. The same twin setup, the ghost pinned at each of the 5 ghost spawns, 20 matches each, 30 bots, default weapon damage, the game's default 15 s freeze time, 8 matches at a time, on the harness's research build of the bot code (upstream master plus the bot code PRs, among them #2176, #2197 and #2186 (merged since)):

  • stuck events at the pocket 13 -> 0 in 100 matches (6 bot episodes -> 0; on ntre_dawn_ctg 8 -> 0 in 50)
  • stuck events 10.9 -> 10.8 a match (paired x1.02, 95 % interval [0.82, 1.27], 52 of 100 pairs down, 44 up); without the three spots under "Known, not changed", x0.98 [0.77, 1.27]
  • FAIL_NO_PATH_EXISTS move failures 1.5 -> 1.2 a match; "fell off the path" 3.0 -> 2.9; kills 48.3 -> 49.3 a match; ghost captures 21 -> 19 of 200 rounds; no fall deaths, no asserts, no crashes in 200 matches
  • the alternatives, measured the same way (50 matches each): moving the two areas without the cut left the pocket's stuck events as they were (8 -> 15); moving 2506 wholly onto the lane made the pocket look hidden (it saw 114 areas instead of 209), and bots, which avoid exposed areas, went through it three times as often (3 -> 32); the cut alone removed them here (9 -> 0) but left one episode on ntre_dawn_ctg, at the old crossing into 2518

• The carve at the rabbitfrog vehicle, at the game's default freeze time (15 s), one comparison. Commit 4 against the same mesh with 694, 4143 and the three pairs through the vehicle put back (two-way), the same twin setup, the ghost pinned at each of the 5 ghost spawns, 5 matches each, 30 bots, default weapon damage, 8 matches at a time (beside another 8-wide batch on the same machine), on the same bot code. No bot was trapped under the vehicle on either mesh; the floor put back costs:

  • at the vehicle 0 -> 123 stuck events in 25 matches (4.9 a match, in 22 of the 25; on ntre_dawn_ctg 0 -> 137), bots pressing its parked feet; the longest episode 12 events
  • stuck events 11.9 -> 25.9 a match (paired x2.05, 95 % interval [1.37, 2.99], 5 of 25 pairs down, 20 up; on ntre_dawn_ctg x1.29 [0.93, 1.83])
  • FAIL_NO_PATH_EXISTS move failures 4.8 -> 6.6 a match; kills 47.7 -> 49.0; ghost captures 4 -> 4 of 50 rounds; no asserts, no crashes in 50 matches

How the pinned-ghost probes work

The offline checks show that the mesh links an area to a spawn. They do not show that a bot will walk there. To test one spot in game, the ghost is placed on it and bots are sent to get it.

• The ghost is placed on the spot by a server cvar. A harness-only neo patch, used on test builds and not part of this PR or any neo PR, adds sv_neo_ghost_spawn_pos "x y z", which replaces the position of the round's ghost spawn. The map file is not edited.
• A spot counts as reached when a bot stands within 40 u of it, or picks the ghost up there rather than on the floor below, where a ghost that rolls off a narrow landing ends up. A wider radius would count a bot on a level above or below.
• Master's mesh runs beside this one on a byte-identical copy of the .bsp under a second name that loads its own .nav, so the same pin runs on both meshes in one batch.

On this map

Both ends of all four ladders were probed (ladder 4's top at both landings), 3 matches each, 12 bots, at a tenth of weapon damage, on the same build. Every probe was reached in 3 of 3 matches on both meshes (first pickup at 10-41 s; ladder 3's top, which bots almost never use, at 101-176 s on both). A ghost pinned on ladder 1's 8 u cap rolls off into the garden, so ladder 1 was checked through the climbs in the comparison above instead.

Known, not changed

• The rabbitfrog vehicle on the capture zone near (2025,3920) is a prop_dynamic helicopter (rabbitfrog_dynamic.mdl) whose collision moves with its animation. It is re-created at every round start, lands within 10 s, and stays parked until the ghost is captured, when it takes off. With the default 15 s freeze time it has landed before anyone moves, so during play it is a fixed obstacle, and the mesh is carved round its parked footprint (commits 1, 3 and 4; the comparison above). With a freeze time under 10 s, as in the test harness, bots can walk under it while it is landing and stay trapped there until the round ends. That landing phase is left to runtime prop avoidance in bot code.
• Two office chairs (prop_physics_multiplayer) start in the 100 u corridor near (-725,1275), and bots climb onto them or push them along. Stuck events there 5.9 -> 3.4 a match, bot episodes a round 0.27 -> 0.40; without #2176 5.4 -> 3.1 and 0.17 -> 0.37. The chairs move, so the mesh is not cut around them; that is runtime prop avoidance in bot code. Stuck events on physics props across the whole map: 3.65 -> 1.15 a match.
• Ladder 4's top (681,1488): a few bots a match slide off the ladder's side onto a ledge under the upper floor's lip, or press the corner of the right-hand landing after dismounting. At master's level on the ladder PR as it was then (0.15 against 0.16 bot episodes a round; without #2176 0.41 against 0.59). #2176 now also takes a climb's exit from the landing the ladder leads to: in 60 matches on this map and ntre_dawn_ctg, climbs kicked backwards off the top went 71 of 627 -> 4 of 604 and stuck events at ladder 4's top 94 -> 30.
• The dead-end room near (775,940): bots pushed into its doorway by teammates press toward a goal on the other side of its wall. Below master (above) and not a mesh matter.