[CrazyAngelm]

Summary

Review of the whole library against the MAX Bot API (schemas of the official Go SDK max-bot-api-client-go) and fixes for all open issues. Version bumped to 0.7.0-alpha (contains breaking changes, see CHANGELOG).

Issues

• Fixes Ответ на callback не работает #34 — AnswerCallbackQueryAsync sends callback_id; NewMessageBody uses AttachmentRequest[] / NewMessageLink
• Fixes FileUploadResult потерял Photos — токен загруженной картинки теперь доступен только через AdditionalProperties #38 — FileUploadResult.Photos / FileId restored, Token filled from photos; XML CDN response is not a token; new IFilesApi.UploadAsync
• Fixes Отсутствие корректной обработки ответа attachment.not.ready при отправке сообщения #22 — flat {"code","message"} errors parsed; MaxAttachmentNotReadyException; only attachment.not.ready is retried (send + edit)
• Fixes При попытке получить список чатов в которых находится бот выдается исключение #23 — GetChatsAsync parses {"chats","marker"}; GetChatListAsync(count, marker)
• Fixes почему библиотека добавляет Эндпоинт /api/max/webhook в основное АПИ ? #35 — WebhookController is abstract (no implicit endpoint in every ASP.NET app); app.MapMaxWebhook()
• Fixes Обязательный параметр url в ConfigureWebhookAsync #36 — ConfigureWebhookAsync() / DeleteWebhookAsync() fall back to Webhook.Endpoint / SecretToken
• Fixes Не заполняется параметр chat в update при отправке сообщений от пользователей #37 — Update.ChatId / Chat / ChatType from message.recipient (and is_channel)
• Fixes Невозможно отправить картинку как Url #15 — AttachmentRequest factories (ImageFromUrl, Image, Video, Audio, File, FromUpload, Sticker, Contact, Location, Share, Keyboard)
• Closes Не пробрасывает payload при запуске бота #16, Исключение при попытке дессериализации ответа в _bot.Messages.GetMessagesAsync #18, Получение присылаемых файлов не работает, вообще, в принципе #20, Некорректная работа метода GetVideoAsync #21, Не возможно получить данные контакта #25 — already fixed in 0.6.x; regression tests + richer attachment/update models
• Supersedes Добавлен Payload в Update для поддержки deeplinks в соответствии с до… #17

Other API mismatches found during review

• Long polling used update_id (absent in MAX API, always 0) as marker → now uses marker from the response
• Default webhook secret header X-Max-Signature → X-Max-Bot-Api-Secret (real webhooks were rejected when a secret was set)
• GetPinnedMessageAsync parses {"message": ...}; AddChatAdminRequest sends {"admins":[...]}
• Incoming attachments merge payload + root fields (filename, size, thumbnail, duration, …); StickerAttachment, ShareAttachment
• New update fields: message_id, user_id, admin_id, title, is_channel, muted_until, start_payload
• Lenient enums for chat status / admin permissions; real package version in User-Agent
• Microsoft.SourceLink.GitHub 8.0.0 → 10.0.401 (vulnerable Microsoft.Build.Tasks.Git made dotnet restore fail with NU1902)

Second commit — fixes from a multi-agent adversarial review of the first commit

• Culture-invariant ids/query values (U+2212 minus broke negative group chat ids on sv-SE/nb-NO/fi-FI)
• Webhook hardening: size + secret checked before the body is read/parsed (controller and MapMaxWebhook share one pipeline), no fallback to unconfigured IOptions<MaxBotOptions>, Webhook.HandlerTimeout applied, secret format validated, options updated only on success: true
• Polling: poison updates are skipped instead of looping forever, marker advances only after a full batch, StopAsync waits for parallel handlers, AllowedUsernames checks the callback presser
• Tolerant attachment parsing; attachment.not.ready retried by SendMessageAsync(SendMessageRequest) too; non-seekable upload streams buffered for retries; derived photo token not serialized next to photos; no trailing GET after resumable video/audio upload; Retry-After in the past handled
• GetChatMembersPageAsync with marker, open_app / clipboard buttons, message_chat_created chat id

Test plan

• dotnet format --verify-no-changes, dotnet format analyzers --verify-no-changes
• dotnet build -c Release -warnaserror
• dotnet test — 722 tests pass on net10.0 / net9.0 / net8.0, line coverage 81.25%
• dotnet pack produces MaxMessenger.Bot.0.7.0-alpha nupkg/snupkg
• CI (Ubuntu + Windows) on the latest head

🤖 Generated with Claude Code

https://claude.ai/code/session_01JWng6Vbuo8rweWS5x8PX56