Repository navigation
Hash Dragon descriptors from serialized bytes - #104
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
|
@coderabbitai review |
|
melo-gonzo
left a comment
There was a problem hiding this comment.
LGTM. Descriptor length and digest now use the exact serialized bytes. Regression tests and publication-race probes confirm that workers reject changed content before starting the worker target.
Return the serialized bytes from atomic JSON publication and use them to bind worker launch descriptors before the published path can change. Cover descriptor mutation during publication for both execution APIs. Signed-off-by: Trent Nelson <trentn@nvidia.com>
2b9219b to
4b901d3
Compare
Dragon launch descriptors were hashed by reopening their published path. A change between publication and that read could make the expected digest describe different content from the coordinator's descriptor.
Return the exact serialized bytes from atomic JSON publication and hash those bytes in the shared and xPOIS launch paths. Workers then reject a descriptor changed during publication before resolving or constructing the worker target.
Validation: 256 focused tests passed, with one optional test skipped. Regression coverage includes shared workers, single-pass xPOIS, and repeated rounds. All repository pre-commit checks passed.