Conversation
9prady9
marked this pull request as ready for review
September 16, 2026 14:58
Contributor
Author
|
@felipeblazing @aminaramoon pls provide inputs on added annotations and suggest any missing locations. ty |
Member
|
/ok to test c9adf6b |
aminaramoon
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libcucascadedomainMotivation
Sirius already annotates queries, pipelines, tasks, and operators, but cuCascade's memory-pressure and tier-transition work is mostly opaque beneath those ranges. This adds a restrained first layer of library-side visibility without annotating allocators, fast try-lock paths, individual buffers, or worker-loop lifetimes.
Conversion labels spell out both endpoints and group lexically under
convert:in the profiler UI:convert:gpu_to_host/convert:host_to_gpu/convert:gpu_to_gpuconvert:host_to_disk/convert:disk_to_hostconvert:gpu_to_disk/convert:disk_to_gpuExisting host-to-GPU phase ranges nest under
convert:host_to_gpu:*.Validation
pixi run -e cuda-13-nightly buildlibcucascade:wait:reservationandlibcucascade:wait:batch_lockwith expected ~20 ms contention lifetimesScope
This intentionally leaves generic converter wrappers, packed legacy converters, detailed phase breakdowns for new directions, and I/O/reactor annotations for a later profiling-driven pass.