Skip to content

Support building docs for publishing via GHA - #3515

Open
fheinecke wants to merge 1 commit into
mainfrom
fred/support-public-doc-builds-1
Open

fheinecke wants to merge 1 commit into
mainfrom
fred/support-public-doc-builds-1

Conversation

@fheinecke

Copy link
Copy Markdown
Collaborator

Description

Currently GHA can only produce docs archives for NVTE_DOCS_DISABLE_PUBLIC_FEATURES: '1', which makes them useful for local testing, but not for public publishing. This makes the option togglable via workflow dispatch triggers, which allows for building these identically to GitLab CI without running through the whole long, expensive build process.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Support building docs for publishing via GHA

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
@fheinecke
fheinecke force-pushed the fred/support-public-doc-builds-1 branch from 834c8e4 to f5d8178 Compare September 14, 2026 18:04
@fheinecke

Copy link
Copy Markdown
Collaborator Author

@fheinecke
fheinecke marked this pull request as ready for review September 14, 2026 18:06
@fheinecke
fheinecke requested a review from ksivaman September 14, 2026 18:06
@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the new manual-dispatch option correctly controlling the existing documentation feature flag.

Summary

  • Public features remain disabled by default for pull requests and other existing invocation paths.
  • Enabling the dispatch input maps the documentation environment variable to "0", matching its existing parsing semantics.

Reviews (1) · Last reviewed commit: "Support building docs for publishing via..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant