refactor(prover): separate outcome evaluation from rendering - #2632
Open
eviehoward wants to merge 1 commit into
Open
refactor(prover): separate outcome evaluation from rendering#2632eviehoward wants to merge 1 commit into
eviehoward wants to merge 1 commit into
Conversation
eviehoward
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
August 6, 2026 13:02
7 tasks
elezar
self-requested a review
August 18, 2026 13:10
|
This pull request has had no activity for 14 days and is now marked stale. It may be closed in 7 days if there is no further activity. |
Contributor
Author
|
I'm still keeping an eye on this, AFAIK it's still mergeable- please let me know if anything needs changing or if a rebase is needed 🙂 |
2000krysztof
suggested changes
Sep 7, 2026
Signed-off-by: Evie Howard <evhoward@redhat.com>
eviehoward
force-pushed
the
2411-separate-outcome-from-rendering/eviehoward
branch
from
September 8, 2026 09:57
5dc783d to
b1dbd85
Compare
Contributor
|
Thanks for addressing my concerns @eviehoward LGTM |
2000krysztof
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves exit-code logic out of the renderers and into prove(), so outcome evaluation happens once in a single place rather than independently in each renderer.
Related Issue
Closes #2411
Changes
Testing
mise run pre-commitpassesChecklist