Run build-logic unit tests in CI - #352
Merged
Merged
Conversation
The root build's test tasks don't reach the included build-logic build, so its unit tests (module-detector, module-rules) never ran in CI. Run them in their own step with ./gradlew -p build-logic test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root build's
testtasks don't reach the includedbuild-logicbuild, so the build-logic unit tests (module-detector: 3, module-rules: 4) never ran in CI. This adds a final step,./gradlew -p build-logic test --stacktrace, which covers every build-logic project, including ones added later.The step adds roughly 25β40s to CI, about half of it for the extra Gradle invocation. Adding
:build-logic:<project>:testpaths to the existingtestDebugstep would save that part, but every new build-logic project would then have to be added to the list by hand.Verification
./gradlew -p build-logic testruns the module-detector (3) and module-rules (4) tests, and all pass.conventionhas no tests.π€ Generated with Claude Code
https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ