Remove small unused declarations - #351
Merged
Merged
Conversation
- Drop the redundant KSP plugin from feature/tasks/impl; moop.android.feature already applies it through moop.android.hilt. - Delete the empty AndroidManifest.xml files of the plain-Kotlin core/model, data/database/api and data/settings/api modules. - Drop three unused imports from Android.kt. - Drop feature/tasks/impl's test dependencies (it has no tests) and the androidx-work-testing catalog entry that only it used. - Add missing final newlines to three build files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanups of unused declarations:
feature/tasks/impl: drop the redundantid "com.google.devtools.ksp".moop.android.featureappliesmoop.android.hilt, which already applies KSP, soksp libs.androidx.hilt.compilerstill runs.<manifest />files of the plain-Kotlin modulescore/model,data/database/apianddata/settings/api. Without an Android plugin, nothing reads them.build-logic/.../Android.kt: drop three unused imports (VersionCatalogsExtension,dependencies,getByType).feature/tasks/impl: drop the test dependencies (work-testing,projects.testing). The module has no test sources. Theandroidx-work-testingcatalog entry, which only this module used, goes too.data/network/api,data/repository/implandfeature/tasks/implbuild files.Verification
:feature:tasks:implcompiles and its HiltWorker KSP (kspDebugKotlin) still runs.:app:compileDebugKotlinpasses../gradlew dependencyGuard manifestShield proguardShieldFast moduleRulespasses, and all baselines are unchanged.π€ Generated with Claude Code
https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ