Add moop.android.room convention plugin - #345
Merged
Merged
Conversation
Move the Room setup out of data/database/impl into a convention that applies KSP and adds room-runtime and the room-compiler processor. Drop room-ktx, an empty artifact since Room 2.7, and the kapt-era room.incremental annotation processor option, which KSP doesn't read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Room setup moves into a convention plugin,
moop.android.room: it applies KSP and addsroom-runtimeandksp(room-compiler).data/database/impl, the only Room module, applies it instead of declaring these itself.Also removed:
room-ktx: since Room 2.7 its APIs live inroom-runtime, and the 2.8.4 artifact only contains a version file. Its catalog entry and dependencyGuard baseline line go with it.annotationProcessorOptionsblock (room.incremental): a kapt-era option that only reached javac. Room runs on KSP, which doesn't read it.Verification
:data:database:implcompiles (main, unit test, androidTest) and its unit tests pass../gradlew dependencyGuardBaselineonly removesandroidx.room:room-ktx:2.8.4.dependencyGuard,manifestShield,proguardShieldFastandmoduleRulespass, and their other baselines are unchanged.π€ Generated with Claude Code
https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ