Detect modules in a value source - #344
Merged
Merged
Conversation
Gradle records every directory the module detector lists as a configuration cache input, so an unrelated change such as a new .DS_Store or core/build discarded the cache. Detecting the modules inside a ValueSource makes the cache compare only the detected modules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle records every directory the module detector lists, and every file it checks, as a configuration cache input. So an unrelated change, such as a new
.DS_Storeor acore/builddirectory, discarded the cache although the module list was the same.ModuleDetectorPluginnow detects the modules inside aValueSource(ModulesValueSource). The cache then compares only the detected module list, one input instead of about 280.findModulesand its unit tests are unchanged.Verification
./gradlew helpafter...develop)core/directory 'core' has changed)core/<name>/build.gradle)ModulesValueSourcechanged), module included./gradlew -q projectslists the same 51 projects../gradlew -p build-logic :module-detector:testpasses (3 tests), and so does:module-detector:validatePluginswith stricter validation enabled.π€ Generated with Claude Code
https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ