Add default module dependencies to convention plugins - #343
Merged
Merged
Conversation
moop.android.library and moop.android.application add :core:model, and the new moop.android.feature (used by the feature/*/impl modules) applies moop.android.library and adds :data:repository:api. Drop the explicit declarations these defaults now cover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ
All seven feature impl modules use Hilt, so the feature convention applies moop.android.hilt and the modules drop their own declaration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convention plugins now add the dependencies that most modules declared by hand:
moop.android.libraryandmoop.android.applicationaddimplementation(project(":core:model")).moop.android.featureappliesmoop.android.libraryandmoop.android.hilt, and addsimplementation(project(":data:repository:api")). The 7feature/*/implmodules use it instead ofmoop.android.library+moop.android.hilt; thefeature/*/apimodules keepmoop.android.library.The explicit declarations these defaults cover are removed:
projects.core.modelfrom 17 Android modules (5 of which didn't use it) andprojects.data.repository.apifrom 4 feature impl modules. The plain-Kotlindata/database/apianddata/settings/apikeep theirprojects.core.modeldependency.Verification
:app:hiltJavaCompileDebugpasses../gradlew dependencyGuard manifestShield proguardShieldFast moduleRulespasses, and./gradlew moduleRulesBaselineleavesmodule-rules.txtunchanged.π€ Generated with Claude Code
https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ