Repository navigation
chore(lane): daily maintenance 2026-10-17 - #126
Merged
Merged
Conversation
…ery host Filed by the fix lane. Fixes #123 - #123: `rel_path::rel_path_tests::file_stem_uses_the_relative_file_name_on_every_host` and `rel_path::rel_path_tests::extension_uses_the_relative_file_name_on_every_host` failed on Windows before the change (`file_stem()` of `dir/a\b.rs` was `Some("b")`, `extension()` of `dir/a.d\b` was `None`) and pass now. `file_stem` / `extension` now split the last `/` component by std's dot rules instead of going through the host `Path`. Re-run: `cargo test -p moon-util --lib uses_the_relative_file_name`. Reviewer: Codex. Its one objection (a `foo.rs/` value built by `RelPathBuf::push(RelPath::empty())` would have lost its stem) is addressed: the split skips the empty trailing component as `Path::file_name` does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Filed by the fix lane.
Fixes #123
rel_path::rel_path_tests::file_stem_uses_the_relative_file_name_on_every_hostandrel_path::rel_path_tests::extension_uses_the_relative_file_name_on_every_hostfailed on Windows before the change (file_stem()ofdir/a\b.rswasSome("b"),extension()ofdir/a.d\bwasNone) and pass now.RelPath::file_stem/extensionnow split the last/component by std's dot rules instead of going through the hostPath. Re-run:cargo test -p moon-util --lib uses_the_relative_file_name.Reviewer: Codex. Its one objection (a
foo.rs/value built byRelPathBuf::push(RelPath::empty())would have lost its stem) is addressed: the split skips the empty trailing component asPath::file_namedoes.README.md,docs/PALETTE_SPEC.md,docs/COMPONENT_AUDIT.mdandcrates/moon-gpui/README.mdmatch the code;docs/GPU_CANVAS_TEXT_API.mdwas skipped because the code it describes has no commits since it was last edited.RelPath::newstill accepts a Windows drive path behind./or a..segment.