Repository navigation
chore(lane): daily maintenance 2026-10-15 - #122
Merged
Merged
Conversation
Filed by the fix lane. Fixes #118 #118: `Output::sort` returned the weight comparison as soon as importance was equal, so two rows with equal importance and weight compared Equal and never reached the documented "Lastly by name" key; the unstable sort kept them in insertion order. The metadata arm now chains importance, weight and name. Test: `equal_importance_and_weight_sort_by_name` in crates/moon-perf/src/implementation/tests.rs pushes `b` then `a` with equal metadata and expects `["a", "b"]`. It failed before (left ["b", "a"]) and passes now. Re-run: cargo test -p moon-perf equal_importance_and_weight_sort_by_name Reviewed by Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunt
Timings::iters_per_sec(crates/moon-perf) divided byDuration::as_millis, which truncates the mean to whole milliseconds. hyperfine reports a fractional mean, and a test with a preset iteration count skips triage, so short runs reach it.infiterations per second; comparing two sub-millisecond runs makes the category meanNaN.implementation::tests::iters_per_sec_keeps_sub_millisecond_precisionfailed on 1384a3d (got 3000 and inf) and passes now.cargo test -p moon-perf --lib iters_per_secauto-foundissue (Legacy PowerShell drops empty native task arguments after 06aa89a #113) carriesneeds-human.docs/COMPONENT_AUDIT.md,crates/moon-ui-gallery/README.md, the Rust highlighter README andCONTRIBUTING.mdmatch the code.