Repository navigation
fix(build): declare raw-window-handle for macOS - #978
Merged
Merged
Conversation
The macOS chart shot (panels/chart/shot/mac.rs) reads the window's AppKit view through raw_window_handle, but the crate was declared only for Windows, so both macOS release slices failed with E0433. Declare it in the macOS block too; the lock already carries 0.6.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The v0.59.0 release run failed on both macOS slices:
panels/chart/shot/mac.rs(from #977) usesraw_window_handle, whichmoon-ui-gpuideclared only undercfg(windows)->E0433 cannot find module or crate raw_window_handle. This declares it in the macOS dependency block as well.Cargo.lockis unchanged (0.6.2 already locked).How to verify
cargo fetch --lockedok,cargo check -p moon-ui-gpuiok on Windows; the macOS probe on this PR must compile.