Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be frank, this is a micro-optimization.
According to Microsoft's NtQueryDirectoryFile documentation, when
FileNamecontains no wildcards, there is at most one matching directory entry. USVFS queries here with exact physical filenames; after fully retrieving the entry, the original implementation still called the internalNtQueryDirectoryFile()again, continuing until it hitSTATUS_NO_MORE_FILESbefore concluding the search. This optimization eliminates that redundant EOF probe.On my machine (i5-12600K, medium-sized modlist with 529 active plugins, using CRDW
ACCELERATEmode to avoid redundant per-file size queries during Skyrim’s startup directory traversal):For the file traversal process1, this eliminated 220,261 redundant
NtQueryDirectoryFilecalls, cutting the traversal time from 21.381 s to 18.590 s—a 2.791 s (13.1%) speedup, though that translates to only about a 3% performance uplift overall.Footnotes
Process creation and basic initialization completed (~4.9 s post-launch) → CommunityShaders first Streamline initialization log entry. ↩