Skip to content

GEOPY-3041: Create Data groups for L2 and LP iterations on predicted data #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 2 commits into from
Sep 1, 2026
Merged

GEOPY-3041: Create Data groups for L2 and LP iterations on predicted data #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
908548d
Change SaveLP directive for more generic name
domfournier Sep 1, 2026
39a5a9a
Update docstring
domfournier Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion simpeg/directives/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
BaseSaveGeoH5,
SaveDataGeoH5,
SaveLogFilesGeoH5,
SaveLPModelGroup,
SaveLPIterationsGroup,
SaveModelGroup,
SaveModelGeoH5,
SavePGIModel,
Expand Down
8 changes: 4 additions & 4 deletions simpeg/directives/_save_geoh5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,9 +536,9 @@ def get_names(
return channel_name, component


class SaveLPModelGroup(SavePropertyGroup):
class SaveLPIterationsGroup(SavePropertyGroup):
"""
Save the model as a property group in the geoh5 file
Group data or model as a property group for the L2 and LP iterations.
"""

def __init__(
Expand All @@ -562,9 +562,9 @@ def get_names(
channel_name, base_name = super().get_names(component, channel, iteration)

if self.irls_directive.metrics.irls_iteration_count == 0:
base_name = "L2 models"
base_name = "L2 iterations"
else:
base_name = "LP models"
base_name = "LP iterations"

return channel_name, base_name

Expand Down
Loading