Repository navigation
GEOPY-196: geoh5py mesh object origin should return a list - #93
Merged
Merged
Conversation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical origin-handling issues remain unresolved in conversion, tests, and the block-model driver.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (3)
What changed in this PR
Updates geoh5py mesh-origin handling from keyed mappings to list-based sequences across utilities and tests.
Changes:
- Replaces string-key origin access with positional indexing.
- Updates mesh conversion and related test expectations.
- Critical follow-up changes remain required for origin conversion, assertions, and block-model driver handling.
| File | Summary |
|---|---|
tests/run_tests/octree_creation/run_test.py |
Uses positional origin access. |
tests/run_tests/grid_model_merger_test.py |
Updates mesh-origin assertions and copying. |
tests/run_tests/block_model_test.py |
Updates block-model origin checks. |
grid_apps/utils.py |
Migrates origin handling; critical issues remain in octree conversion (2 votes), octree-origin assertions (3 votes), and block-model driver compatibility (3 votes). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+40
to
+41
| origin = ( | ||
| entity.origin |
| cell_size = [] | ||
| cell_count = [] | ||
| dimensions = [] | ||
| origin = mesh.origin |
| cell_size = [] | ||
| cell_count = [] | ||
| dimensions = [] | ||
| origin = mesh.origin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-196 - geoh5py mesh object origin should return a list