Repository navigation
DEVOPS-1133: Pushing new hash version - #2
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new Dependabot auto-merge workflow grants write permissions on all PRs without an explicit Dependabot-only gate, which is a security risk.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Pins MiraGeoscience/CI-tools reusable workflow references to immutable commit SHAs to satisfy DEVOPS-1133 (“pin all GitHub actions and reusable workflows to hash”), and adds an auto-merge workflow for Dependabot PRs.
Changes:
- Updated multiple existing workflows to use a fixed CI-tools commit SHA (with version comments) instead of
@v3/ prerelease tags. - Added a new
dependabot-auto-mergeworkflow that calls the CI-tools reusable workflow pinned to a SHA.
File summaries
| File | Description |
|---|---|
| .github/workflows/security_scan.yml | Pins Zizmor reusable workflows to a CI-tools commit SHA. |
| .github/workflows/python_deploy_prod.yml | Pins production release reusable workflows to a CI-tools commit SHA. |
| .github/workflows/python_deploy_dev.yml | Pins development publish reusable workflows to a CI-tools commit SHA. |
| .github/workflows/pr_jira_actions.yml | Pins JIRA PR actions reusable workflow to a CI-tools commit SHA. |
| .github/workflows/issue_to_jira.yml | Pins JIRA issue creation reusable workflow to a CI-tools commit SHA. |
| .github/workflows/dependabot-auto-merge.yml | Introduces Dependabot auto-merge via a pinned CI-tools reusable workflow. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| jobs: | ||
| call-workflow-dependabot-auto-merge: | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-dependabot-auto-merge.yml@7241532854727d993872b67fc761139b8438615b # v3.12.0 | ||
| permissions: |
48e447c to
70ec1af
Compare
|
|
Pin all GitHub Actions and reusable workflow references to immutable commit hashes, and add the dependabot auto-merge and WIP status workflows.
70ec1af to
c1989cb
Compare
|
|
DEVOPS-1133 - pin all GitHub actions and reusable workflows to hash
Expands moving GitHub Actions tags to the full semver tag pointing at the same commit, then pins every
uses:to a commit hash with a dependabot-readable version comment.Tags expanded in this repo:
MiraGeoscience/CI-tools/.github/workflows/reusable-jira-issue_to_jira.yml@v3 -> @v3.12.0MiraGeoscience/CI-tools/.github/workflows/reusable-jira-pr_actions.yml@v3 -> @v3.12.0MiraGeoscience/CI-tools/.github/workflows/reusable-python-publish_rattler_package.yml@v3.7.0-alpha.1 -> @v3.12.0MiraGeoscience/CI-tools/.github/workflows/reusable-python-publish_pypi_package.yml@v3.7.0-alpha.1 -> @v3.12.0MiraGeoscience/CI-tools/.github/workflows/reusable-python-release_conda_assets.yml@v3 -> @v3.12.0MiraGeoscience/CI-tools/.github/workflows/reusable-python-release_pypi_assets.yml@v3 -> @v3.12.0MiraGeoscience/CI-tools/.github/workflows/reusable-zizmor-advanced-security.yml@v3 -> @v3.12.0MiraGeoscience/CI-tools/.github/workflows/reusable-zizmor-annotate.yml@v3 -> @v3.12.0Workflows added:
.github/workflows/dependabot-auto-merge.yml.github/workflows/wip-status.ymlAll
MiraGeoscience/CI-toolsreusable workflows are pinned to7241532854727d993872b67fc761139b8438615b(v3.12.0).