Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
promptText()passed the same string as bothdefaultandplaceholderto@clack/prompts. Clack's text prompt has nodefaultoption — its option isdefaultValue— so that key was ignored and the hint could only ever be rendered as the placeholder.This builds the options in a small helper, keeps the default strictly as a placeholder, and adds unit tests for both cases so a hint can never be seeded into the prompt as input text.
Refs #278: the placeholder text in that report (
Ask Mcode to do anything) is drawn by the MiniMax Code TUI composer inMiniMax-AI/minimax-code, not by this prompt wrapper. This change removes the only place in this repository where a hint could be passed to a prompt as a value.Tests
bun test test/utils/prompt.test.ts— 3 passbun run typecheckbun run lintNeed help on this PR? Tag
@codesmith-botwith what you need.