Repository navigation
Cold-replace a checkpoint that cannot be restored - #819
Merged
Merged
Conversation
SaladDay
deleted the
cold-replace-a-checkpoint-that-cannot-be-restored
branch
October 22, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A microsandbox resume that failed before native restoration (missing or damaged snapshot, failed qualification, or a helper that cannot read the snapshot format) left its durable restore admission open. Every later attempt returned
unconfirmed, so the allocation stayed inrestoringuntil retention expiry, and the Session's pending input waited until its public deadline. Seen on mx on 2026-10-22.The Core–Sandbox Provider protocol gains the
ResumeoutcomeErrCheckpointUnusable(node wire codecheckpoint_unusable): the adapter durably closed the exact attempt before native dispatch, and the snapshot cannot be restored. A laterObserveOnlyreports it again, and it is never returned once native restoration was dispatched.ExpireUnusableCheckpoint(running,restoring, samecompute_revision), and the ordinary expiry cleanup runs from there. A qualified Session then continues through the existing cold replacement. Capacity-pressure expiry still applies only tosuspendedallocations.RestoreSandbox.RestoreAttemptClosedpath.docs/sandbox-provider.md,contracts/agents-api/node-generation-protocol.mdand their Chinese mirrors, and the helper README.Checks:
python3 scripts/build-microsandbox-provider.py testgo testwith-runfilters on the restore, compute, retention and pressure tests ininternal/execution,internal/deploymentanddeploymentpg, plus./internal/sandbox/...go vetmake check-docsAn independent review found two problems, both fixed: a failed target lookup left the admission open, and the helper README was not updated.
Need help on this PR? Tag
@codesmith-botwith what you need.