Repository navigation
Keep client-aborted requests out of persistence errors - #818
Merged
SaladDay merged 1 commit intoOct 22, 2026
Merged
Conversation
SaladDay
deleted the
keep-client-aborted-requests-out-of-persistence-errors
branch
October 22, 2026 10:41
A request whose client disconnected fails its storage call with the ended request context. The API reported it as a 500 internal_error and logged a persistence failure. The unmapped-error writer now returns nothing once the request context has ended; the request log already records the request as aborted. The Agents and Files mappers reuse the shared writer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request whose client disconnected fails its storage call with the ended request context. The API answered it as a 500
internal_errorand loggedoac-core persistence operation failed(seen on mx on 2026-10-22 at 07:40 UTC).writeInternalErrornow writes nothing once the request context has ended; the request log already records such a request asaborted. The Agents and Files mappers reuse the shared writer instead of their own copies.Checks:
go test ./internal/api/ -run 'TestInternalErrorAfterClientAbort|TestSharedPersistenceErrors|TestResourceNotFoundErrorSurfaces',go vet ./...in services/core.Need help on this PR? Tag
@codesmith-botwith what you need.