Repository navigation
Wake placement as soon as capacity or preparation is ready - #809
Merged
Merged
Conversation
Placement now hints the lanes only when it failed for capacity, so a generation rollout or reset does not double every lane's scans. A direct lane frees no node slot, and the freed-slot wake is a plain channel send.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What users see
Faster cold start of a hosted Session on a full node. No behavior or API change.
Changes
placement.ErrNodeUnavailable) now hints every existing node lane, so demand suspension and checkpoint expiry start immediately instead of on the lane's next 5 s tick.ReleaseAllocation,ReleaseLostCompute) wakes the manager's placement loop; direct lanes free no node slot and send nothing, instead of waiting for its next 5 s tick.Measured
Test cluster, 5 Sessions, node max_active 3 (Core logs + node journal):
Tests
TestCapacityFailedPlacementHintsNodeLanes: a capacity-failed placement hints the node lane.TestFreedSlotWakesPlacement: a freed slot wakes placement and coalesces.go vet ./...(services/core) andgo test ./internal/execution -run 'Placement|Wake|Suspend|FreedSlot|Capacity'pass.Need help on this PR? Tag
@codesmith-botwith what you need.