Skip to content

Deduplicate duplicate RPM candidates - #250

Merged
dsteeley merged 13 commits into
mainfrom
fix/deduplicate-rpm-candidates
Oct 21, 2026
Merged

dsteeley merged 13 commits into
mainfrom
fix/deduplicate-rpm-candidates

Conversation

@dsteeley

@dsteeley dsteeley commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Deduplicate candidates with matching strong checksums before invoking DNF solver.
  • For weak or differing checksum metadata, download candidates and compare RPM SHA-256 hashes. Fail before solver use when duplicate bytes conflict or verification fails.

Validation

  • Python resolver fixtures pass with installed DNF.
  • Rust formatting and diff checks pass.
  • Single test locally that a container image can be built using this version of rpmoci pulling from a JFrog source that has multiple copies of the same package reporting different checksums.

🤖 Generated with Claude Code

@dsteeley
dsteeley force-pushed the fix/deduplicate-rpm-candidates branch from f1a4e59 to d422d38 Compare October 21, 2026 10:19
@dsteeley
dsteeley changed the base branch from main to fix/cargo-deny-remediation October 21, 2026 10:19
Base automatically changed from fix/cargo-deny-remediation to main October 21, 2026 10:45

@ChrisGerrett ChrisGerrett left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not looked in detail at the test code, but my reading of resolve.py does align with what I expect from your description.

I'd love to see more comments because it does take some effort to read the flow, but I don't consider that a blocker.

@dsteeley
dsteeley merged commit 436c131 into main Oct 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants