Repository navigation
Deduplicate duplicate RPM candidates - #250
Merged
Merged
Conversation
Initialize Python when attaching so DNF-backed calls run in tests and commands. Install gcc in the Fedora test container and fix the Clippy warning. Co-Authored-By: Claude Code <noreply@anthropic.com>
dsteeley
force-pushed
the
fix/deduplicate-rpm-candidates
branch
from
October 21, 2026 10:19
f1a4e59 to
d422d38
Compare
ChrisGerrett
approved these changes
Oct 21, 2026
ChrisGerrett
left a comment
There was a problem hiding this comment.
I've not looked in detail at the test code, but my reading of resolve.py does align with what I expect from your description.
I'd love to see more comments because it does take some effort to read the flow, but I don't consider that a blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
🤖 Generated with Claude Code