Repository navigation
feat(catalogs): record the resource version of an imported catalog - #24
Merged
Merged
Conversation
`catalogs import` now records a resource version without `--resource-version`: a JP catalog's source version, else the version in an international file name `catalog_<version>_<language>.bin` (none for `main`), the name `fetch` and the cache use. The version also becomes the default label. An invalid `--resource-version`, or one that differs from a JP catalog's source version, is an error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catalogs fetchrecords the resource version it downloads, butcatalogs importrecorded one only with--resource-version. Nowimporttakes, in order:--resource-version, checked like a configured catalog version;.source.jsonsidecar); a different--resource-versionis an error;catalog_<version>_<language>.bin, the namefetchand the cache use (none formain).The recorded version is also the default label, as with
fetch.docs/assets.mddescribes the order.Tests:
tests/test_cli_assets.pyimportscatalog_1.0.0.201_en.binandcatalog_main_en.binand checks the option's precedence and errors.🤖 Generated with Claude Code