Skip to content

docs(edge-routing): §ER8 describes the interaction that exists; no right-click menu - #360

Merged
MerciHanrim merged 3 commits into
mainfrom
docs/er8-interaction
Oct 17, 2026
Merged

MerciHanrim merged 3 commits into
mainfrom
docs/er8-interaction

Conversation

@MerciHanrim

@MerciHanrim MerciHanrim commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

§ER8 describes the interaction that exists

docs/edge-routing.md §ER8 still read like the first design, written before the shapes-and-bends editor of §ER16 was built. It listed a right-click menu on a connection ("Orthogonal route" / "Curved route", "Remove point", "Reset route"), only Curved and Orthogonal, a draggable mid-segment handle for adding points, and arrow-key nudging as deferred. The app has no right-click menu: the canvas wires no context menu, and on the phone and under the edit lock it suppresses the browser's own (Canvas.tsx onContextMenu). Found while answering whether the app supports right-click at all.

What changes

  • §ER8 now lists what the app offers, each item checked against Inspector.tsx RouteField and RouteBends.tsx, with §ER16 as the reference for the rules:
  • the Route select: Orthogonal / Curved / Straight (Straight was missing); choosing Curved or Straight drops the bend points;
  • Add bend: the next click on the line inserts a bend point on that segment, snapped to the grid along it (Alt skips grid snapping but keeps the point on the segment), or Enter inserts one in the middle of the longest editable segment;
  • moving a bend handle by drag or by the arrow keys (Shift for a bigger step); removing it with Delete or Backspace, the last one making the route automatic;
  • Reset to automatic for a Manual route; the keyboard path for all of it; one undo entry each; the edit lock; the phone (read-only select, no bend tools).
  • A new §ER8.1 keeps the earlier design intent apart from the current description and says it was not built; the list describes the currently implemented interactions (no decision about later work).
  • Second commit (e551634, Lumi's review): the Alt wording above, and §ER8.1's last sentence no longer says a right-click menu is not planned.
  • Corrected together (f1456a6, Lumi): §ER16.2 described the same Alt-click as "at the click"; it now says, as §ER8, that Alt skips grid snapping but keeps the point on the segment (bendAtClick / onSegment). The other Alt descriptions were checked: §ER16.2's handle drag "(Alt: free)" and diagram-layout.md DL4.3 "Alt moves one freely" describe moving a bend handle, where Alt does give a free position (RouteBends.tsx), so they stay. The code comment above bendAtClick also says "(Alt: free)"; it is code, outside this docs PR.

Checks

  • Docs only: no product code, no version. check:change-declaration: nothing built or shipped changed, no declaration needed. check:control-bytes: ok.
  • PR CI on f1456a6, run 39033140945: success (checks, e2e shards 1–6, production bundle, PWA).
  • PR CI on e551634, run 39031565900: success (checks, e2e shards 1–6, production bundle, PWA).
  • PR CI on 8610176, run 39027858014: success (checks, e2e shards 1–6, production bundle, PWA).

…ght-click menu

§ER8 still read like the first design, written before the editor of §ER16
was built: it listed a right-click menu on a connection ("Orthogonal
route" / "Curved route", "Remove point", "Reset route"), only Curved and
Orthogonal, a draggable mid-segment handle for adding points, and arrow-key
nudging as deferred. None of the menu exists — the canvas wires no context
menu (on the phone and under the edit lock it suppresses the browser's own,
`Canvas.tsx` `onContextMenu`).

Now §ER8 lists what the app offers, checked against `Inspector.tsx`
`RouteField` and `RouteBends.tsx`, with §ER16 as the reference for the
rules: the Route select (Orthogonal / Curved / Straight), Add bend (a click
on the line, snapped along the segment, or Enter), moving a bend handle by
drag or the arrow keys, removing it with Delete or Backspace, Reset to
automatic for a Manual route, the keyboard path, undo, the edit lock and
the phone. A new §ER8.1 keeps the earlier design intent apart, says it was
not built, and that a right-click menu is not planned.

Docs only: no product code, no version. `check:change-declaration`: nothing
built or shipped changed, no declaration needed. `check:control-bytes` ok.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Deploying cozy-loop-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1456a6
Status: ✅  Deploy successful!
Preview URL: https://ff3b3cbc.cozy-loop-studio.pages.dev
Branch Preview URL: https://docs-er8-interaction.cozy-loop-studio.pages.dev

View logs

…o plan beyond the current interactions (Lumi's review)

- Alt skips grid snapping but keeps the point on the segment (`bendAtClick`
  / `onSegment`); it was described as "at the click".
- The last sentence of §ER8.1 said a right-click menu is not planned; this
  change only aligns the document with the current function, it decides
  nothing about later work. It now says the list describes the currently
  implemented interactions.

Docs only. `check:change-declaration`: nothing built or shipped changed.
`check:control-bytes` ok.
…d (Lumi's review)

§ER16.2 described the Alt-click of Add bend as "at the click"; the code
(`bendAtClick` -> `onSegment` in `routeMap.ts`) skips only the grid snap
and keeps the point on the nearest segment. Now worded as §ER8: "Alt skips
grid snapping but keeps the point on the segment".

Checked the other Alt descriptions: §ER16.2's handle drag "(Alt: free)"
and `diagram-layout.md` DL4.3 "Alt moves one freely" describe MOVING a
bend handle, where Alt does give a free position (`RouteBends.tsx`
`moveTo(g, e.altKey ? f : snapPoint(f))`), so they stay. The comment above
`bendAtClick` says "(Alt: free)" too; it is code, outside this docs PR.

Docs only. `check:change-declaration`: nothing built or shipped changed.
`check:control-bytes` ok.
@MerciHanrim
MerciHanrim merged commit cea0115 into main Oct 17, 2026
11 checks passed
@MerciHanrim
MerciHanrim deleted the docs/er8-interaction branch October 17, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant