Repository navigation
docs(edge-routing): §ER8 describes the interaction that exists; no right-click menu - #360
Merged
Merged
Conversation
…ght-click menu
§ER8 still read like the first design, written before the editor of §ER16
was built: it listed a right-click menu on a connection ("Orthogonal
route" / "Curved route", "Remove point", "Reset route"), only Curved and
Orthogonal, a draggable mid-segment handle for adding points, and arrow-key
nudging as deferred. None of the menu exists — the canvas wires no context
menu (on the phone and under the edit lock it suppresses the browser's own,
`Canvas.tsx` `onContextMenu`).
Now §ER8 lists what the app offers, checked against `Inspector.tsx`
`RouteField` and `RouteBends.tsx`, with §ER16 as the reference for the
rules: the Route select (Orthogonal / Curved / Straight), Add bend (a click
on the line, snapped along the segment, or Enter), moving a bend handle by
drag or the arrow keys, removing it with Delete or Backspace, Reset to
automatic for a Manual route, the keyboard path, undo, the edit lock and
the phone. A new §ER8.1 keeps the earlier design intent apart, says it was
not built, and that a right-click menu is not planned.
Docs only: no product code, no version. `check:change-declaration`: nothing
built or shipped changed, no declaration needed. `check:control-bytes` ok.
Deploying cozy-loop-studio with
|
| Latest commit: |
f1456a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ff3b3cbc.cozy-loop-studio.pages.dev |
| Branch Preview URL: | https://docs-er8-interaction.cozy-loop-studio.pages.dev |
…o plan beyond the current interactions (Lumi's review) - Alt skips grid snapping but keeps the point on the segment (`bendAtClick` / `onSegment`); it was described as "at the click". - The last sentence of §ER8.1 said a right-click menu is not planned; this change only aligns the document with the current function, it decides nothing about later work. It now says the list describes the currently implemented interactions. Docs only. `check:change-declaration`: nothing built or shipped changed. `check:control-bytes` ok.
…d (Lumi's review) §ER16.2 described the Alt-click of Add bend as "at the click"; the code (`bendAtClick` -> `onSegment` in `routeMap.ts`) skips only the grid snap and keeps the point on the nearest segment. Now worded as §ER8: "Alt skips grid snapping but keeps the point on the segment". Checked the other Alt descriptions: §ER16.2's handle drag "(Alt: free)" and `diagram-layout.md` DL4.3 "Alt moves one freely" describe MOVING a bend handle, where Alt does give a free position (`RouteBends.tsx` `moveTo(g, e.altKey ? f : snapPoint(f))`), so they stay. The comment above `bendAtClick` says "(Alt: free)" too; it is code, outside this docs PR. Docs only. `check:change-declaration`: nothing built or shipped changed. `check:control-bytes` ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
§ER8 describes the interaction that exists
docs/edge-routing.md§ER8 still read like the first design, written before the shapes-and-bends editor of §ER16 was built. It listed a right-click menu on a connection ("Orthogonal route" / "Curved route", "Remove point", "Reset route"), only Curved and Orthogonal, a draggable mid-segment handle for adding points, and arrow-key nudging as deferred. The app has no right-click menu: the canvas wires no context menu, and on the phone and under the edit lock it suppresses the browser's own (Canvas.tsxonContextMenu). Found while answering whether the app supports right-click at all.What changes
Inspector.tsxRouteFieldandRouteBends.tsx, with §ER16 as the reference for the rules:e551634, Lumi's review): the Alt wording above, and §ER8.1's last sentence no longer says a right-click menu is not planned.f1456a6, Lumi): §ER16.2 described the same Alt-click as "at the click"; it now says, as §ER8, that Alt skips grid snapping but keeps the point on the segment (bendAtClick/onSegment). The other Alt descriptions were checked: §ER16.2's handle drag "(Alt: free)" anddiagram-layout.mdDL4.3 "Alt moves one freely" describe moving a bend handle, where Alt does give a free position (RouteBends.tsx), so they stay. The code comment abovebendAtClickalso says "(Alt: free)"; it is code, outside this docs PR.Checks
check:change-declaration: nothing built or shipped changed, no declaration needed.check:control-bytes: ok.f1456a6, run 39033140945: success (checks, e2e shards 1–6, production bundle, PWA).e551634, run 39031565900: success (checks, e2e shards 1–6, production bundle, PWA).8610176, run 39027858014: success (checks, e2e shards 1–6, production bundle, PWA).